Skip to content
Snippets Groups Projects

Add image-style config

Merged Add image-style config
issue/custom_elements-3468348:3468348-image-style-config into 3.x
All threads resolved!
Merged Bálint Junkuncz requested to merge issue/custom_elements-3468348:3468348-image-style-config into 3.x
All threads resolved!

Closes #3468348

Merge request reports

Merged results pipeline #257291 skipped

Merged results pipeline skipped for 1340e7b0

Merged by Roderik MuitRoderik Muit 9 months ago (Aug 18, 2024 2:27pm UTC)

Loading

Pipeline #257297 passed with warnings

Stage: build
Stage: validate
Stage: test

Pipeline passed with warnings for 92aa9899 on 3.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Roderik Muit
  • Roderik Muit
    Roderik Muit @roderik
    Developer

    About applying it in build:

    • Modify FileCeFieldFormatter::getFieldItemProperties() to output image style URL instead, in 'url'
    • See LupusImageHelper line 479 and work back from there
    • Make any helper functions for this purpose in the formatter private (not protected). That way we can delete them later without thinking about compatibility. Reason: I suspect we may want to add more code later, which adds all the other relevant data properties. And that may end up being in a separate ImageHelper class? But that's probably not for this issue, I guess.
  • Roderik Muit requested changes

    requested changes

  • Bálint Junkuncz added 1 commit

    added 1 commit

    Compare with previous version

  • Bálint Junkuncz added 1 commit

    added 1 commit

    • 7eb5a7b3 - missing functionality by feedback

    Compare with previous version

  • Bálint Junkuncz added 1 commit

    added 1 commit

    Compare with previous version

  • Bálint Junkuncz added 1 commit

    added 1 commit

    Compare with previous version

  • Bálint Junkuncz added 1 commit

    added 1 commit

    Compare with previous version

  • Bálint Junkuncz added 1 commit

    added 1 commit

    Compare with previous version

  • Bálint Junkuncz added 1 commit

    added 1 commit

    Compare with previous version

  • Roderik Muit
  • Bálint Junkuncz added 1 commit

    added 1 commit

    Compare with previous version

  • Roderik Muit added 1 commit

    added 1 commit

    • ff967135 - Fix PHP warnings for unknown array keys; add some dots to summary lines.

    Compare with previous version

  • Roderik Muit added 18 commits

    added 18 commits

    Compare with previous version

    Toggle commit list
  • Roderik Muit resolved all threads

    resolved all threads

  • Roderik Muit approved this merge request

    approved this merge request

  • Roderik Muit merged

    merged

    • Please register or sign in to reply