Stabilise CI build 2.x
Merged
Stabilise CI build 2.x
2 unresolved threads
2 unresolved threads
Closes #3427892
Merge request reports
Activity
added 1 commit
- b4270efc - clean up DefaultContentEntityProcessor (favour for phpstan)
53 * The entity type manager. 54 * 55 * @return $this 56 */ 57 public function setEntityTypeManager(EntityTypeManagerInterface $entityTypeManager) { 58 $this->entityTypeManager = $entityTypeManager; 59 return $this; 60 } 61 62 /** 63 * Gets the entity type manager. 64 * 65 * @return \Drupal\Core\Entity\EntityTypeManagerInterface 66 * The entity type manager. 67 */ 68 public function getEntityTypeManager() { -
!34 (comment 281469) Changed by this suggestion.
changed this line in version 8 of the diff
30 protected $entityTypeManager; 31 32 /** 33 * The request stack. 34 * 35 * @var \Symfony\Component\HttpFoundation\RequestStack 36 */ 37 protected $requestStack; 38 39 /** 40 * DefaultContentEntityProcessor constructor. 41 * 42 * @param \Symfony\Component\HttpFoundation\RequestStack $request_stack 43 * The request stack. 44 */ 45 public function __construct(RequestStack $request_stack) { -
this is potentially a BC break. I don't think it makes sense to change this for the stable 2.x branch for no reason. We should configure the testing pipeline for 2.x to match the current code as good as possible and keep it stable instead. small fixes we can do of course, but let's focus on changes in 3.x
changed this line in version 8 of the diff
Please register or sign in to reply