Skip to content
Snippets Groups Projects

implement change

1 open thread

Closes #3524432

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lio Novelli resolved all threads

    resolved all threads

  • 240 foreach ($entities as $key => $entity) {
    241 $custom_elements[$key]->addCacheableDependency($ce_display);
    242 $custom_elements[$key]->setTag($ce_name);
    243 }
    244
    240 245 if ($entity_view_display = $this->checkLayoutBuilderDisplay($ce_display, current($entities))) {
    241 // Skip processing of display components and let layout builder
    242 // render everything.
    246 // Build the layout builder content for the entities.
    243 247 foreach ($entities as $key => $entity) {
    244 $custom_elements[$key]->addCacheableDependency($ce_display);
    245 $custom_elements[$key]->setTag($ce_name);
    246 248 $this->buildLayoutBuilderContent($entity, $custom_elements[$key], $entity_view_display);
    247 249 }
    250 // Additionally process fields according to CE display
    251 $this->buildEntityComponentFields($entities, $custom_elements, $ce_display, $account);
    • Looks good. One idea that I had to have more backward compatibility is to add additional checkbox to add fields to CE display. A config option that is only visible if layout builder is checked and disabled by default.

    • Please register or sign in to reply
  • One idea that I had to have more backward compatibility is to add additional checkbox to add fields to CE display. A config option that is only visible if layout builder is checked and disabled by default.

  • Lio Novelli approved this merge request

    approved this merge request

  • added 4 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading