Issue #3531838 by rduterte: Add path include/exclude support warning control

Closes #3531838

This adds a setting to hide the config warning on specific admin paths using the request_path condition plugin. Supports wildcards and an optional toggle to switch between include/exclude behavior.

added 3 commits

• ea7b696a...9e581f2f - 2 commits from branch project:1.0.x
• 6727762b - Merge branch '1.0.x' into '3531838-exclude-include-paths-config-warning'

Compare with previous version

added 1 commit

• 924ea860 - Issue #3531838 by rduterte: Add path include/exclude support warning control

Compare with previous version

added 1 commit

• 78b73584 - Issue #3531838 by rduterte: resolve phpcs warnings and refactor path warning control

Compare with previous version

resolved all threads

added 1 commit

• 8f1bc4f4 - Adding language changes as suggested in #13

Compare with previous version

added 1 commit

• a1543863 - Issue #3531838 by rduterte: Refactor Config Warning to support multiple condition plugins

Compare with previous version

added 1 commit

• 43cbcc1f - Issue #3531838 by rduterte: Add a safety check if there's no configuration

Compare with previous version

resolved all threads

Thanks! I took a look through and left some comments. I also should mention that there's no hook_update_N() to update the config for existing installs, but I don't know if we're worried about that (there's no release afaict).

added 1 commit

• dfe0aaec - Issue #3531838 by rduterte: Apply suggested improvements for condition plugin...

Compare with previous version

resolved all threads

Thanks @rduterte, looks great to me! I picked up on some super minor points, and I haven't had a chance to actually run it myself.

added 1 commit

• 72388298 - Issue #3531838 by rduterte: Apply minor improvements

Compare with previous version

resolved all threads

@rduterte Loverly stuff, thanks! I noticed just one additional thing I hadn't picked up on earlier, it's again unlikely to cause an issue in practice but perhaps better safe than sorry.

added 1 commit

• ac10fab8 - Issue #3531838 by rduterte: Remove early out and move it to for safety check.

Compare with previous version

resolved all threads

Thanks @rduterte, looks great to me! Ran it locally:

• You can't save an invalid path in the condition config.
• The warning shows up on the path given.
• Negate reverses the path condition as expected.

Future tasks

• Mention in the release notes that existing installs should reinstall the module or otherwise update their configuration to include conditions.
• It might be nice to set up some automated tests to help prevent regressions in the condition handling.

resolved all threads

merged