Fix proposal for #3435910
Merge request reports
Activity
931 string $name, 932 StorageInterface $sync, 933 StorageInterface $split, 934 StorageInterface $transforming 935 ): void { 936 if ($sync->exists($name)) { 937 // If a partial split has already been written, delete it. 938 if ($split->exists(self::SPLIT_PARTIAL_PREFIX . $name)) { 939 $split->delete(self::SPLIT_PARTIAL_PREFIX . $name); 940 } 941 /** 942 * On import, we will assume that an empty array config file means the 943 * config should not be imported (should be removed if it exists). 944 * @see \Drupal\config_split\ConfigSplitManager::mergeSplit() 945 */ 946 $split->write($name, []); I don't know if an empty array is a legitimate config. probably not. But I would much rather save the fact that the config should be deleted in some other way. Like writing
['config_split' => 'deleted config']
or something along the lines of that. This makes it much easier to see what is going on and we can make sure that this never reaches the active config because we know config split needs to deal with it. We do this for sequence keys already. Ie config split saves sequences with deterministic keys and then when merging the keys are stripped again.changed this line in version 4 of the diff
I'm still not sure what the best structure would be. I made e259f419, then 49e5e6b6. Is it better like this? Note that createPatch wants an array as an argument, so I used [FALSE] and not FALSE. The tests still pass...
Edited by Gaël Gosset
- Resolved by Gaël Gosset
mentioned in commit issue/config_split-3435910@e259f419
marked this merge request as draft from issue/config_split-3435910@41baf783
mentioned in commit issue/config_split-3435910@49e5e6b6
added 1 commit
- Resolved by Gaël Gosset
- Resolved by Gaël Gosset
added 2 commits