Skip to content
Snippets Groups Projects

Fixed some issues

Merged Fixed some issues
issue/commerce_giftcard-3481609:3481609-fix-cspell-eslint-phpcs-phpstan into 2.x
8 unresolved threads
Merged Julian Pustkuchen requested to merge issue/commerce_giftcard-3481609:3481609-fix-cspell-eslint-phpcs-phpstan into 2.x
8 unresolved threads

Closes #3481609

Merge request reports

Merge request pipeline #325487 failed

Stage: build
Stage: validate
Stage: test

Merge request pipeline failed for cbf992cd

Approval is optional
Code Quality is loading
Test summary results are being parsed
Full report

Merged by Julian PustkuchenJulian Pustkuchen 3 months ago (Oct 31, 2024 6:42am UTC)

Merge details

  • Changes merged into 2.x with 6047ae42 (commits were squashed).
  • Did not delete the source branch.

Pipeline #325684 failed

Stage: build
Stage: validate
Stage: test

Pipeline failed for 6047ae42 on 2.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/Entity/Giftcard.php
122 122 if (!$this->get('balance')->isEmpty()) {
123 123 return $this->get('balance')->first()->toPrice();
124 124 }
125 return NULL;
125 126 }
  • Julian Pustkuchen
    Julian Pustkuchen @Anybody started a thread on the diff
    • src/Entity/GiftcardTransaction.php
    76 75 if (!$this->get('amount')->isEmpty()) {
    77 76 return $this->get('amount')->first()->toPrice();
    78 77 }
    78 return NULL;
  • Julian Pustkuchen
    Julian Pustkuchen @Anybody started a thread on the diff
    • src/Entity/GiftcardTransaction.php
    106 106 public function getComment() {
    107 107 $text = $this->get('comment')->value;
    108 108 if ($text) {
    109 if ($this->get('variables')->first() && $this->get('variables')->first()->toArray()) {
    110 return new TranslatableMarkup($text, $this->get('variables')->first()->toArray());
    109 $variables = $this->get('variables')->first();
    110 if ($variables && $variables->toArray()) {
    111 return \Drupal::translation()->formatString($text, $variables->toArray());
  • Julian Pustkuchen
    Julian Pustkuchen @Anybody started a thread on the diff
    • src/Entity/GiftcardTransaction.php
    106 106 public function getComment() {
    107 107 $text = $this->get('comment')->value;
    108 108 if ($text) {
    109 if ($this->get('variables')->first() && $this->get('variables')->first()->toArray()) {
    110 return new TranslatableMarkup($text, $this->get('variables')->first()->toArray());
    109 $variables = $this->get('variables')->first();
    110 if ($variables && $variables->toArray()) {
    111 return \Drupal::translation()->formatString($text, $variables->toArray());
    111 112 }
    112 113 else {
    113 return new TranslatableMarkup($text);
    114 return $text;
  • Julian Pustkuchen
    Julian Pustkuchen @Anybody started a thread on an old version of the diff
    • .cspell.json 0 → 100644
    9 "Gift cards",
    10 "autofills",
    11 "completition",
    12 "messasge",
    13 "fewfsfs",
    14 "Hegal"
    15 ],
    16 "dictionaries": ["en-US"],
    17 "files": [
    18 "**/*.php",
    19 "**/*.twig",
    20 "**/*.yml",
    21 "**/*.json"
    22 ]
    23 }
    24
  • Julian Pustkuchen
    Julian Pustkuchen @Anybody started a thread on an old version of the diff
    • .cspell.json 0 → 100644
    1 {
    2 "version": "0.1",
    3 "ignoreWords": [
    4 "giftcards",
    5 "Giftcards",
    6 "giftcard",
    7 "Giftcard",
    8 "Gift card",
    9 "Gift cards",
    10 "autofills",
    11 "completition",
    12 "messasge",
    13 "fewfsfs",
    14 "Hegal"
  • Julian Pustkuchen
    Julian Pustkuchen @Anybody started a thread on an old version of the diff
    • .cspell.json 0 → 100644
    1 {
    2 "version": "0.1",
    3 "ignoreWords": [
    4 "giftcards",
    5 "Giftcards",
    6 "giftcard",
    7 "Giftcard",
    8 "Gift card",
    9 "Gift cards",
    10 "autofills",
    11 "completition",
  • Julian Pustkuchen
    Julian Pustkuchen @Anybody started a thread on an old version of the diff
    • .cspell.json 0 → 100644
    1 {
    2 "version": "0.1",
    3 "ignoreWords": [
    4 "giftcards",
    5 "Giftcards",
    6 "giftcard",
    7 "Giftcard",
    8 "Gift card",
    9 "Gift cards",
    10 "autofills",
    11 "completition",
    12 "messasge",
  • Ankit Pathak added 1 commit

    added 1 commit

    • 8f261149 - Using _cspell_words variable and fixing other typos.

    Compare with previous version

  • rhovland added 1 commit

    added 1 commit

    • 2ef3472e - Remove extraneous words from the project dictionary and correct spelling errors.

    Compare with previous version

  • rhovland added 1 commit

    added 1 commit

    • 9d6cc5cd - Refactor checkout pane constructor to make it more durable

    Compare with previous version

  • rhovland added 2 commits

    added 2 commits

    • 3f8f3d78 - Fix create() formatting in GiftcardOrderRefundForm
    • bf7608d0 - Correct the syntax of the GiftcardListBuilder constructor to match drupal core

    Compare with previous version

  • rhovland added 2 commits

    added 2 commits

    • 5b3d3037 - Fix missing use statement in GiftcardListBuilder
    • cbf992cd - Remove unused use statements in GiftcardRedemption

    Compare with previous version

  • Julian Pustkuchen merged

    merged

    • Please register or sign in to reply