Issue #3519904 by jsacksick: commerce_cart_commerce_order_delete() should be...

Issue #3519904 by jsacksick: commerce_cart_commerce_order_delete() should be skipped for CLI requests.

Closes #3519904

modules/cart/src/CartSession.php

@@ -48,15 +48,22 @@ class CartSession implements CartSessionInterface {
    * {@inheritdoc}
    */
   public function deleteCartId($cart_id, $type = self::ACTIVE) {
-    $key = $this->getSessionKey($type);
-    $ids = $this->session->get($key, []);
-    $ids = array_diff($ids, [$cart_id]);
-    if (!empty($ids)) {
-      $this->session->set($key, $ids);
+    try {
+      $key = $this->getSessionKey($type);
+      $ids = $this->session->get($key, []);
+      $ids = array_diff($ids, [$cart_id]);
+      if (!empty($ids)) {
+        $this->session->set($key, $ids);
+      }
+      else {
+        // Remove the empty list to allow the system to clean up empty sessions.
+        $this->session->remove($key);
+      }
     }
-    else {
-      // Remove the empty list to allow the system to clean up empty sessions.
-      $this->session->remove($key);
+    catch (\RuntimeException) {
+      // Do nothing, a \RuntimeException can be triggered when this method is
+      // invoked by the cron job for expiring cart orders. Logging this wouldn't
+      // really help.
     }
   }