Skip to content
Snippets Groups Projects

Draft: Issue #3468552: Allow creating payment method on free orders

Closed Draft: Issue #3468552: Allow creating payment method on free orders
1 unresolved thread
1 unresolved thread

Closes #3468552

Merge request reports

Approval is optional
Code Quality is loading
Test summary results are being parsed

Closed by Jakub PiaseckiJakub Piasecki 5 months ago (Aug 28, 2024 1:44pm UTC)

Merge details

  • The changes were not merged into 8.x-2.x.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 373 429 // The billing profile is provided either because the order is free,
    374 430 // or the selected gateway does not support stored payment methods.
    375 431 // If it's the former, stop here.
    376 if ($this->order->isPaid() || $this->order->getTotalPrice()->isZero()) {
    432 if ($this->order->isPaid() || ($this->order->getTotalPrice()->isZero() && !$this->configuration['payment_methods_free_orders']) || $this->collectBillingProfileOnly()) {
    • It looks weird to me that we're first checking:

      ($this->order->getTotalPrice()->isZero() && !$this->configuration['payment_methods_free_orders'])

      And then calling ```$this->collectBillingProfileOnly()```` which does the following:

      return $this->order->getTotalPrice()->isZero() && empty($this->configuration['payment_methods_free_orders']);

      perhaps we can remove the total price check from this condition block?

    • Jakub Piasecki changed this line in version 6 of the diff

      changed this line in version 6 of the diff

    • Please register or sign in to reply
  • added 1 commit

    • 9240539c - Rename interface and subscriber, add balance check

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Jakub Piasecki added 8 commits

    added 8 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Jakub Piasecki added 2 commits

    added 2 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Jakub Piasecki added 8 commits

    added 8 commits

    • 15dd19e1...e459cb3c - 2 commits from branch project:8.x-2.x
    • f970290e - Merge branch '8.x-2.x' into 3468552-allow-creating-payment
    • 157a3cd4 - Define PaymentPaneBase
    • ffde97a9 - Replace FILTER_PAYMENT_OPTIONS event with FILTER_PAYMENT_GATEWAYS
    • fd132359 - Kernel test of the ZeroBalanceOrderSubscriber
    • 16b27880 - Rename PaymentCheckoutPaneBase
    • 8dd471fd - Add test coverage for checkout

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Jakub Piasecki changed target branch from 8.x-2.x to 3.0.x

    changed target branch from 8.x-2.x to 3.0.x

  • Jakub Piasecki changed target branch from 3.0.x to 8.x-2.x

    changed target branch from 3.0.x to 8.x-2.x

  • Please register or sign in to reply
    Loading