Issue #3447691 - Change the container element for empty variation fields to a SPAN element (!257) · Merge requests · project / commerce · GitLab

Snippets Groups Projects

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Issue - Change the container element for empty variation fields to a SPAN element

issue/commerce-3447691:3447691-variation-field-renderer into 8.x-2.x

1 unresolved thread

Merged rhovland requested to merge issue/commerce-3447691:3447691-variation-field-renderer into 8.x-2.x 1 year ago

1 unresolved thread

Closes #3447691

Activity

rhovland added 1 commit 1 year ago
added 1 commit

41a457ea - Fix failing ProductVariationFieldRendererTest

Compare with previous version
Jonathan Sacksick @jsacksick started a thread on an old version of the diff 1 year ago

modules/product/src/ProductVariationFieldRenderer.php

115	115	// Ensure that a <div> is rendered even if the field is empty, to allow
Jonathan Sacksick @jsacksick 1 year ago Maintainer Perhaps we need to change the comment to say span here :). Edited 1 year ago by Jonathan Sacksick Jonathan Sacksick changed this line in version 3 of the diff 1 year ago changed this line in version 3 of the diff Please register or sign in to reply

Jonathan Sacksick added 1 commit 1 year ago

added 1 commit

0aaa4d0d - Update ProductVariationFieldRenderer.php

Compare with previous version

Jonathan Sacksick added 5 commits 1 year ago

added 5 commits

0aaa4d0d...901b7c61 - 2 commits from branch project:8.x-2.x
6e843e64 - Change the container element for empty variation fields to a SPAN element
e8f2e865 - Fix failing ProductVariationFieldRendererTest
4e43278f - Update ProductVariationFieldRenderer.php

Compare with previous version

Toggle commit list

Jonathan Sacksick merged 1 year ago

merged

Please register or sign in to reply