Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
commerce
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
commerce
Merge requests
!251
Issue
#3443376
: Fix eslint in commerce_checkout
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Issue
#3443376
: Fix eslint in commerce_checkout
issue/commerce-3443376:3443376-fix-the-eslint
into
8.x-2.x
Overview
0
Commits
2
Pipelines
5
Changes
2
Merged
Dmytrii Kaiun
requested to merge
issue/commerce-3443376:3443376-fix-the-eslint
into
8.x-2.x
1 year ago
Overview
0
Commits
2
Pipelines
5
Changes
2
Expand
Closes
#3443376
0
0
Merge request reports
Compare
8.x-2.x
version 3
ee5c93c6
1 year ago
version 2
dd8ec636
1 year ago
version 1
e75a6ffd
1 year ago
8.x-2.x (base)
and
latest version
latest version
9956542f
2 commits,
1 year ago
version 3
ee5c93c6
2 commits,
1 year ago
version 2
dd8ec636
1 commit,
1 year ago
version 1
e75a6ffd
1 commit,
1 year ago
2 files
+
12
−
10
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
modules/checkout/js/commerce_checkout.admin.js
+
8
−
9
Options
@@ -74,11 +74,12 @@
$
(
rowObject
.
table
)
.
find
(
'
tr.region-message
'
)
.
each
(
function
()
{
const
$that
=
$
(
this
);
const
message
=
this
;
const
$message
=
$
(
message
);
// If the dragged row is in this region, but above the message row, swap
// it down one space.
if
(
$
that
.
prev
(
'
tr
'
).
get
(
0
)
===
$
message
.
prev
(
'
tr
'
).
get
(
0
)
===
rowObject
.
group
[
rowObject
.
group
.
length
-
1
]
)
{
// Prevent a recursion problem when using the keyboard to move rows
@@ -90,16 +91,14 @@
rowObject
.
swap
(
'
after
'
,
this
);
}
}
const
nextRow
=
message
.
nextElementSibling
;
// This region has become empty.
if
(
$that
.
next
(
'
tr
'
).
is
(
'
:not(.draggable)
'
)
||
$that
.
next
(
'
tr
'
).
length
===
0
)
{
$that
.
removeClass
(
'
region-populated
'
).
addClass
(
'
region-empty
'
);
if
(
!
nextRow
||
!
nextRow
.
matches
(
'
.draggable
'
))
{
$message
.
removeClass
(
'
region-populated
'
).
addClass
(
'
region-empty
'
);
}
// This region has become populated.
else
if
(
$that
.
i
s
(
'
.region-empty
'
))
{
$
that
.
removeClass
(
'
region-empty
'
).
addClass
(
'
region-populated
'
);
else
if
(
message
.
matche
s
(
'
.region-empty
'
))
{
$
message
.
removeClass
(
'
region-empty
'
).
addClass
(
'
region-populated
'
);
}
});
},
Loading