Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
commerce
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
commerce
Merge requests
!16
Removed plugin manager code that enforces false module dependencies
Code
Review changes
Check out branch
Download
Patches
Plain diff
Open
Removed plugin manager code that enforces false module dependencies
issue/commerce-3184470:3184470-condition-manager-should
into
8.x-2.x
Overview
0
Commits
1
Pipelines
0
Changes
1
Open
Dimitris Bozelos
requested to merge
issue/commerce-3184470:3184470-condition-manager-should
into
8.x-2.x
4 years ago
Overview
0
Commits
1
Pipelines
0
Changes
1
Expand
Closes
#3184470
0
0
Merge request reports
Compare
8.x-2.x
8.x-2.x (HEAD)
and
latest version
latest version
e34ea0f3
1 commit,
4 years ago
1 file
+
0
−
5
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
src/ConditionManager.php
+
0
−
5
Options
@@ -71,11 +71,6 @@ class ConditionManager extends DefaultPluginManager implements ConditionManagerI
throw
new
PluginException
(
sprintf
(
'The condition "%s" must define the "%s" property.'
,
$plugin_id
,
$required_property
));
}
}
$entity_type_id
=
$definition
[
'entity_type'
];
if
(
!
$this
->
entityTypeManager
->
getDefinition
(
$entity_type_id
))
{
throw
new
PluginException
(
sprintf
(
'The condition "%s" must specify a valid entity type, "%s" given.'
,
$plugin_id
,
$entity_type_id
));
}
}
/**
Loading