Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
commerce
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
commerce
Commits
d4b51f04
Commit
d4b51f04
authored
1 year ago
by
Jonathan Sacksick
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3406432
followup by jsacksick: Stop ignoring the toRenderArray() deprecations().
parent
4f8e8401
Branches
Branches containing commit
Tags
Tags containing commit
2 merge requests
!235
Issue #3115150 by mbovan: Submitting add to cart form with empty quantity...
,
!205
Issue #3349465 by tBKoT, jsacksick, bojanz: Update several VAT rates and setup...
Pipeline
#60479
passed
1 year ago
Stage: build
Stage: validate
Stage: test
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
modules/promotion/src/Plugin/views/area/CouponRedemption.php
+1
-3
1 addition, 3 deletions
modules/promotion/src/Plugin/views/area/CouponRedemption.php
phpstan-baseline.neon
+0
-23
0 additions, 23 deletions
phpstan-baseline.neon
with
1 addition
and
26 deletions
modules/promotion/src/Plugin/views/area/CouponRedemption.php
+
1
−
3
View file @
d4b51f04
...
@@ -195,9 +195,7 @@ class CouponRedemption extends AreaPluginBase {
...
@@ -195,9 +195,7 @@ class CouponRedemption extends AreaPluginBase {
$order_total
[
'#suffix'
]
=
'</div>'
;
$order_total
[
'#suffix'
]
=
'</div>'
;
$response
=
new
AjaxResponse
();
$response
=
new
AjaxResponse
();
if
(
isset
(
$order_total
))
{
$response
->
addCommand
(
new
ReplaceCommand
(
'[data-drupal-selector="order-total-summary"]'
,
$order_total
));
$response
->
addCommand
(
new
ReplaceCommand
(
'[data-drupal-selector="order-total-summary"]'
,
$order_total
));
}
$response
->
addCommand
(
new
InsertCommand
(
'[data-drupal-selector="'
.
$inline_form
[
'#attributes'
][
'data-drupal-selector'
]
.
'"]'
,
$inline_form
));
$response
->
addCommand
(
new
InsertCommand
(
'[data-drupal-selector="'
.
$inline_form
[
'#attributes'
][
'data-drupal-selector'
]
.
'"]'
,
$inline_form
));
$response
->
addCommand
(
new
PrependCommand
(
'[data-drupal-selector="'
.
$inline_form
[
'#attributes'
][
'data-drupal-selector'
]
.
'"]'
,
[
'#type'
=>
'status_messages'
]));
$response
->
addCommand
(
new
PrependCommand
(
'[data-drupal-selector="'
.
$inline_form
[
'#attributes'
][
'data-drupal-selector'
]
.
'"]'
,
[
'#type'
=>
'status_messages'
]));
...
...
This diff is collapsed.
Click to expand it.
phpstan-baseline.neon
+
0
−
23
View file @
d4b51f04
...
@@ -210,15 +210,6 @@ parameters:
...
@@ -210,15 +210,6 @@ parameters:
count: 1
count: 1
path: modules/product/src/Plugin/Validation/Constraint/ProductVariationSkuConstraintValidator.php
path: modules/product/src/Plugin/Validation/Constraint/ProductVariationSkuConstraintValidator.php
-
message: """
#^Call to deprecated method toRenderArray\\(\\) of class Drupal\\\\Core\\\\Url\\:
in drupal\\:10\\.1\\.0 and is removed from drupal\\:11\\.0\\.0\\. There is no
replacement\\.$#
"""
count: 1
path: modules/product/src/ProductListBuilder.php
-
-
message: "#^\\\\Drupal calls should be avoided in classes, use dependency injection instead$#"
message: "#^\\\\Drupal calls should be avoided in classes, use dependency injection instead$#"
count: 1
count: 1
...
@@ -244,11 +235,6 @@ parameters:
...
@@ -244,11 +235,6 @@ parameters:
count: 1
count: 1
path: modules/promotion/src/Plugin/views/area/CouponRedemption.php
path: modules/promotion/src/Plugin/views/area/CouponRedemption.php
-
message: "#^Variable \\$order_total in isset\\(\\) always exists and is not nullable\\.$#"
count: 1
path: modules/promotion/src/Plugin/views/area/CouponRedemption.php
-
-
message: """
message: """
#^Call to deprecated function system_time_zones\\(\\)\\:
#^Call to deprecated function system_time_zones\\(\\)\\:
...
@@ -270,15 +256,6 @@ parameters:
...
@@ -270,15 +256,6 @@ parameters:
count: 1
count: 1
path: modules/store/src/Form/StoreTypeForm.php
path: modules/store/src/Form/StoreTypeForm.php
-
message: """
#^Call to deprecated method toRenderArray\\(\\) of class Drupal\\\\Core\\\\Url\\:
in drupal\\:10\\.1\\.0 and is removed from drupal\\:11\\.0\\.0\\. There is no
replacement\\.$#
"""
count: 1
path: modules/store/src/StoreListBuilder.php
-
-
message: "#^Method Drupal\\\\commerce_tax\\\\Form\\\\TaxTypeForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#"
message: "#^Method Drupal\\\\commerce_tax\\\\Form\\\\TaxTypeForm\\:\\:save\\(\\) should return int but return statement is missing\\.$#"
count: 1
count: 1
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment