Issue #3478603 by sidgrafix, omarlopesino, ushma, jsacksick: Commerce...

Issue #3478603 by sidgrafix, omarlopesino, ushma, jsacksick: Commerce promotion warning is preventing editing views field configuration for bundle fields.

modules/price/commerce_price.module

@@ -55,9 +55,9 @@ function commerce_price_configurable_language_insert(ConfigurableLanguage $langu
 function commerce_price_form_views_ui_config_item_form_alter(&$form, FormStateInterface $form_state) {
   /** @var \Drupal\views\Plugin\views\field\EntityField $handler */
   $handler = $form_state->get('handler');
-  if ($handler instanceof EntityField && !empty($handler->definition['entity_type']) && !empty($handler->options['field_name'])) {
+  if ($handler instanceof EntityField && !empty($handler->definition['entity_type'])) {
     $entity_type_id = $handler->definition['entity_type'];
-    $field_name = $handler->definition['field_name'];
+    $field_name = $handler->definition['field_name'] ?? NULL;
     /** @var \Drupal\Core\Entity\EntityFieldManagerInterface $field_manager */
     $field_manager = \Drupal::service('entity_field.manager');
     $field_definitions = $field_manager->getFieldStorageDefinitions($entity_type_id);

modules/promotion/commerce_promotion.module

@@ -99,12 +99,12 @@ function commerce_promotion_form_views_ui_config_item_form_alter(&$form, FormSta
   $handler = $form_state->get('handler');
   if ($handler instanceof EntityField && !empty($handler->definition['entity_type'])) {
     $entity_type_id = $handler->definition['entity_type'];
-    $field_name = $handler->definition['field_name'];
+    $field_name = $handler->definition['field_name'] ?? NULL;
     /** @var \Drupal\Core\Entity\EntityFieldManagerInterface $field_manager */
     $field_manager = \Drupal::service('entity_field.manager');
     $field_definitions = $field_manager->getFieldStorageDefinitions($entity_type_id);
-    $field_definition = $field_definitions[$field_name];
-    if ($entity_type_id == 'commerce_promotion' && $field_definition->getType() == 'datetime') {
+    $field_definition = $field_definitions[$field_name] ?? NULL;
+    if ($entity_type_id == 'commerce_promotion' && $field_definition?->getType() == 'datetime') {
       unset($form['options']['type']['#options']['datetime_custom']);
       unset($form['options']['type']['#options']['datetime_default']);
       unset($form['options']['type']['#options']['datetime_plain']);