Skip to content
Snippets Groups Projects

Issue #3459188 by DYdave: PHPCS on GitlabCI: Fixed all validation errors such...

Merged David Suissa requested to merge issue/colorbox-3459188:3459188-gitlabci-fix-phpcs into 2.1.x

https://www.drupal.org/project/colorbox/issues/3459188

:white_check_mark: PHPCS: Fixed all errors reported on GitlabCI:

  • Fixed all validation errors such dependency injection, code formatting, use states ordering and any other issues reported.
  • Required phpcs and phpstan validation jobs to pass.

Mostly:

  • Automated fixes with: phpcbf web/modules/contrib/colorbox/
  • Fixed the remaining issues manually.

Testing locally: phpcs web/modules/contrib/colorbox/, with the correct phpcs.xml.dist file.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading