Skip to content
Snippets Groups Projects

Issue #3466984 by DYdave: Stylelint on GitlabCI: Fixed all validation errors,...

https://www.drupal.org/project/colorbox/issues/3466984

Fixed Stylelint errors on GitlabCI: :white_check_mark:

  • Fixed all prettier/prettier, order/properties-order, and other types of errors, based on report, mostly automated fixes with the --fix flag.
  • Disabled rule selector-id-pattern since these CSS IDs are provided by the colorbox JS library and are not defined by the module, so they can't really be changed.
  • Required stylelint validation job to pass.

Testing locally:

cd web/core
./node_modules/.bin/stylelint --ignore-path ./.stylelintignore --formatter verbose --config ./.stylelintrc.json ../modules/contrib/colorbox/**/*.css

Merge request reports

Merge train pipeline #251955 passed with warnings

Merge train pipeline passed with warnings for 1571d935

Code Quality is loading
Test summary results are being parsed

Merged by Paul McKibbenPaul McKibben 6 months ago (Aug 12, 2024 5:21pm UTC)

Loading

Pipeline #251957 passed with warnings

Pipeline passed with warnings for 1571d935 on 2.1.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading