Skip to content

Issue #3466984 by DYdave: Stylelint on GitlabCI: Fixed all validation errors,...

David Suissa requested to merge issue/colorbox-3466984:3466984-gitlabci-fix-stylelint into 2.1.x

https://www.drupal.org/project/colorbox/issues/3466984

Fixed Stylelint errors on GitlabCI: ✅

  • Fixed all prettier/prettier, order/properties-order, and other types of errors, based on report, mostly automated fixes with the --fix flag.
  • Disabled rule selector-id-pattern since these CSS IDs are provided by the colorbox JS library and are not defined by the module, so they can't really be changed.
  • Required stylelint validation job to pass.

Testing locally:

cd web/core
./node_modules/.bin/stylelint --ignore-path ./.stylelintignore --formatter verbose --config ./.stylelintrc.json ../modules/contrib/colorbox/**/*.css

Merge request reports