Skip to content
Snippets Groups Projects

Issue #3423376: Add Drupal Gitlab templates

Merged Steffen Schlaer requested to merge issue/cloudflare-3423376:3423376-add-drupal-gitlab into 2.0.x
1 unresolved thread

Closes #3423376

Merge request reports

Merge request pipeline passed for 86c47c3d

Approval is optional

Merged by Kirill RoskoliiKirill Roskolii 10 months ago (Mar 29, 2024 7:47am UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thank you very much for this Steffen,

    Can you please also generate a baseline for PHPStan so we can have a green pipeline for a start and follow up on existing issues later.

  • added 1 commit

    • 3ba12de7 - fix: resolve assertTrue and assertFalse accept only two arguments

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Steffen Schlaer
    Steffen Schlaer @it-cru started a thread on an outdated change in commit 6b3260e4
  • 56 56 # variables:
    57 57 # SKIP_ESLINT: '1'
    58 58
    59 #
    60 # Linting jobs are passing so any issue that breaks them should fix them.
    • Author Maintainer

      NIT: Wording could be changed here.

      Suggested change
      60 # Linting jobs are passing so any issue that breaks them should fix them.
      60 # Linting jobs are passing so any issue that breaks them should be get fixed.
    • Alex Pott changed this line in version 10 of the diff

      changed this line in version 10 of the diff

    • My english was correct. But if it feels wrong to you then I will fix it.

      I changed this to Fail pipeline if linting jobs fail. keeping it simple and correct.

      My original sentence might be easier to parse if I wrote it like Linting jobs are passing, therefore, any issue that breaks them should fix them.

    • Please register or sign in to reply
  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • e39c6f92 - Test Drupal 9 as supposed we support it

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • 5c675b3f - Drupal 9 compatibility is a lie

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • b2125e5e - Better ignoring of test api keys

    Compare with previous version

  • Alex Pott added 1 commit

    added 1 commit

    • 86c47c3d - Better ignoring of test api keys pt 2

    Compare with previous version

  • Please register or sign in to reply
    Loading