Issue #3423376: Add Drupal Gitlab templates
1 unresolved thread
Closes #3423376
Merge request reports
Activity
Filter activity
added 1 commit
- 77790070 - chore: fix reported errors from PHPCS (1st round)
added 1 commit
- b5149b37 - chore: fix reported errors from PHPCS (2nd round)
added 1 commit
- c70231e1 - chore: fix reported errors from PHPCS (3rd round)
added 1 commit
- 4940f1e4 - chore: replace assertSame() with assertTrue() and assertFalse()
- Resolved by Steffen Schlaer
Thank you very much for this Steffen,
Can you please also generate a baseline for PHPStan so we can have a green pipeline for a start and follow up on existing issues later.
added 1 commit
- 3ba12de7 - fix: resolve assertTrue and assertFalse accept only two arguments
56 56 # variables: 57 57 # SKIP_ESLINT: '1' 58 58 59 # 60 # Linting jobs are passing so any issue that breaks them should fix them. changed this line in version 10 of the diff
My english was correct. But if it feels wrong to you then I will fix it.
I changed this to
Fail pipeline if linting jobs fail.
keeping it simple and correct.My original sentence might be easier to parse if I wrote it like
Linting jobs are passing, therefore, any issue that breaks them should fix them.
Please register or sign in to reply