Skip to content
Snippets Groups Projects
Commit c3e1345d authored by Yas Naoi's avatar Yas Naoi
Browse files

Issue #3260523 by yas, kumikoono: fix TypeError on createCollection()...

Issue #3260523 by yas, kumikoono: fix TypeError on createCollection() (K8sMetricsNodeCollection and K8sMetricsPodCollection)
parent 92dc931c
No related branches found
No related tags found
1 merge request!622Issue #3260523: fix TypeError on createCollection() (K8sMetricsNodeCollection and K8sMetricsPodCollection))
......@@ -27,8 +27,12 @@ class K8sMetricsNodeRepository extends Repository {
/**
* {@inheritdoc}
*/
protected function createCollection(array $response): K8sMetricsNodeCollection {
return new K8sMetricsNodeCollection($response['items']);
protected function createCollection($response): K8sMetricsNodeCollection {
// K8s API server may return a string '404 page not found', not an array.
return new K8sMetricsNodeCollection(is_array($response)
? $response['items']
: ['items' => []]
);
}
/**
......
......@@ -20,8 +20,12 @@ class K8sMetricsPodRepository extends Repository {
/**
* {@inheritdoc}
*/
protected function createCollection(array $response): K8sMetricsPodCollection {
return new K8sMetricsPodCollection($response['items']);
protected function createCollection($response): K8sMetricsPodCollection {
// K8s API server may return a string '404 page not found', not an array.
return new K8sMetricsPodCollection(is_array($response)
? $response['items']
: ['items' => []]
);
}
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment