Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
C
ckeditor5_plugin_pack
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
ckeditor5_plugin_pack
Merge requests
!11
3469035: Parse as boolean use_default_markers value in form submit
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
3469035: Parse as boolean use_default_markers value in form submit
issue/ckeditor5_plugin_pack-3469035:1.2.x
into
1.2.x
Overview
0
Commits
3
Pipelines
0
Changes
1
Merged
alex baron
requested to merge
issue/ckeditor5_plugin_pack-3469035:1.2.x
into
1.2.x
6 months ago
Overview
0
Commits
3
Pipelines
0
Changes
1
Expand
in the form submit of highlight.php the value use_default_markers must be boolean . The cleanValues function render integer so the value must be cast as bool.
0
0
Merge request reports
Viewing commit
40e84fe2
Prev
Next
Show latest version
1 file
+
1
−
1
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
40e84fe2
3469035: Fix coding standard
· 40e84fe2
Alex Baron
authored
6 months ago
modules/ckeditor5_plugin_pack_highlight/src/Plugin/CKEditor5Plugin/Highlight.php
+
1
−
1
Options
@@ -280,7 +280,7 @@ class Highlight extends CKEditor5PluginDefault implements CKEditor5PluginConfigu
public
function
submitConfigurationForm
(
array
&
$form
,
FormStateInterface
$form_state
):
void
{
$values
=
$form_state
->
cleanValues
()
->
getValues
();
$this
->
configuration
[
'options'
]
=
$values
[
'custom_marker_wrapper'
]
??
[];
$this
->
configuration
[
'use_default_markers'
]
=
(
bool
)
$values
[
'use_default_markers'
];
$this
->
configuration
[
'use_default_markers'
]
=
(
bool
)
$values
[
'use_default_markers'
];
}
/**
Loading