Skip to content
Snippets Groups Projects
Commit 2fa23fcf authored by Wim Leers's avatar Wim Leers
Browse files

Issue #3347168 by Wim Leers, jonathan1055: Match core's code quality checks: cspell

parent fa133588
No related branches found
Tags 8.x-1.4
1 merge request!18Resolve #3347168 "Gitlab ci template 1.1.2 cspell"
Pipeline #162235 failed with stages
in 2 minutes and 45 seconds
# RFC terminology.
delims
# Technology terminology.
hotlinking
# Technology names.
flysystem
lighttpd
# Drupal core terminology.
validatable
# CDN terminology.
farfuture
nocssjs
# README.
Hasselt
......@@ -86,13 +86,13 @@ class CdnSettingsTest extends UnitTestCase {
'status' => TRUE,
'mapping' => [
'type' => 'simple',
'domain' => '[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80',
'domain' => '[F3DC:BA98:7654:3210:F3DC:BA98:7654:3210]:80',
'conditions' => [],
],
'scheme' => '//',
],
['*' => '[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80'],
['[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80'],
['*' => '[F3DC:BA98:7654:3210:F3DC:BA98:7654:3210]:80'],
['[F3DC:BA98:7654:3210:F3DC:BA98:7654:3210]:80'],
],
'simple, on, one empty condition, scheme-relative' => [
[
......@@ -175,7 +175,7 @@ class CdnSettingsTest extends UnitTestCase {
'status' => TRUE,
'mapping' => [
'type' => 'complex',
'fallback_domain' => '[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:42',
'fallback_domain' => '[F3DC:BA98:7654:3210:F3DC:BA98:7654:3210]:42',
'domains' => [
0 => [
'type' => 'simple',
......@@ -196,7 +196,7 @@ class CdnSettingsTest extends UnitTestCase {
'scheme' => '//',
],
[
'*' => '[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:42',
'*' => '[F3DC:BA98:7654:3210:F3DC:BA98:7654:3210]:42',
'css' => 'static.example.com',
'jpg' => 'static.example.com',
'jpeg' => 'static.example.com',
......@@ -204,7 +204,7 @@ class CdnSettingsTest extends UnitTestCase {
'zip' => 'downloads.example.com',
],
[
'[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:42',
'[F3DC:BA98:7654:3210:F3DC:BA98:7654:3210]:42',
'static.example.com',
'downloads.example.com',
],
......@@ -340,7 +340,7 @@ class CdnSettingsTest extends UnitTestCase {
/**
* @covers ::getLookupTable
*/
public function testAutobalancedWithoutConditions() {
public function testAutoBalancedWithoutConditions() {
$this->expectException(ConfigValueException::class);
$this->expectExceptionMessage("It does not make sense to apply auto-balancing to all files, regardless of extension.");
$this->createCdnSettings([
......
......@@ -135,7 +135,7 @@ class FileUrlGeneratorTest extends UnitTestCase {
'public://something.else',
'//cdn.example.com/sites/default/files/something.else',
],
'managed public file (spublic public imple)' => [
'managed public file (simple)' => [
'public://simple.css',
'//static.example.com/sites/default/files/simple.css',
],
......@@ -148,6 +148,7 @@ class FileUrlGeneratorTest extends UnitTestCase {
FALSE,
],
'unicode' => [
// cspell:disable-next-line
'public://újjáépítésérol — 100% in B&W.jpg',
'//img1.example.com/sites/default/files/%C3%BAjj%C3%A1%C3%A9p%C3%ADt%C3%A9s%C3%A9rol%20%E2%80%94%20100%25%20in%20B%26W.jpg',
],
......@@ -156,8 +157,10 @@ class FileUrlGeneratorTest extends UnitTestCase {
'//img2.example.com/sites/default/files/llama%2520.jpg',
],
'reserved characters in RFC3986' => [
'public://gendelims :?#[]@ subdelims !$&\'()*+,;=.something',
'//cdn.example.com/sites/default/files/gendelims%20%3A%3F%23%5B%5D%40%20subdelims%20%21%24%26%27%28%29%2A%2B%2C%3B%3D.something',
// cspell:disable
'public://gen-delims :?#[]@ sub-delims !$&\'()*+,;=.something',
'//cdn.example.com/sites/default/files/gen-delims%20%3A%3F%23%5B%5D%40%20sub-delims%20%21%24%26%27%28%29%2A%2B%2C%3B%3D.something',
// cspell:enable
],
];
......@@ -211,6 +214,7 @@ class FileUrlGeneratorTest extends UnitTestCase {
FALSE,
],
'unicode' => [
// cspell:disable-next-line
'public://újjáépítésérol — 100% in B&W.jpg',
'//img1.example.com/subdir/sites/default/files/%C3%BAjj%C3%A1%C3%A9p%C3%ADt%C3%A9s%C3%A9rol%20%E2%80%94%20100%25%20in%20B%26W.jpg',
],
......@@ -219,8 +223,10 @@ class FileUrlGeneratorTest extends UnitTestCase {
'//img2.example.com/subdir/sites/default/files/llama%2520.jpg',
],
'reserved characters in RFC3986' => [
'public://gendelims :?#[]@ subdelims !$&\'()*+,;=.something',
'//cdn.example.com/subdir/sites/default/files/gendelims%20%3A%3F%23%5B%5D%40%20subdelims%20%21%24%26%27%28%29%2A%2B%2C%3B%3D.something',
// cspell:disable
'public://gen-delims :?#[]@ sub-delims !$&\'()*+,;=.something',
'//cdn.example.com/subdir/sites/default/files/gen-delims%20%3A%3F%23%5B%5D%40%20sub-delims%20%21%24%26%27%28%29%2A%2B%2C%3B%3D.something',
// cspell:enable
],
];
......@@ -305,6 +311,7 @@ class FileUrlGeneratorTest extends UnitTestCase {
FALSE,
],
'unicode' => [
// cspell:disable-next-line
'public://újjáépítésérol — 100% in B&W.jpg',
'//cdn.example.com/sites/default/files/%C3%BAjj%C3%A1%C3%A9p%C3%ADt%C3%A9s%C3%A9rol%20%E2%80%94%20100%25%20in%20B%26W.jpg',
],
......@@ -313,8 +320,8 @@ class FileUrlGeneratorTest extends UnitTestCase {
'//cdn.example.com/sites/default/files/llama%2520.jpg',
],
'reserved characters in RFC3986' => [
'public://gendelims :?#[]@ subdelims !$&\'()*+,;=.something',
'//cdn.example.com/sites/default/files/gendelims%20%3A%3F%23%5B%5D%40%20subdelims%20%21%24%26%27%28%29%2A%2B%2C%3B%3D.something',
'public://gen-delims :?#[]@ sub-delims !$&\'()*+,;=.something',
'//cdn.example.com/sites/default/files/gen-delims%20%3A%3F%23%5B%5D%40%20sub-delims%20%21%24%26%27%28%29%2A%2B%2C%3B%3D.something',
],
];
......@@ -368,6 +375,7 @@ class FileUrlGeneratorTest extends UnitTestCase {
FALSE,
],
'unicode' => [
// cspell:disable-next-line
'public://újjáépítésérol — 100% in B&W.jpg',
'//cdn.example.com/subdir/sites/default/files/%C3%BAjj%C3%A1%C3%A9p%C3%ADt%C3%A9s%C3%A9rol%20%E2%80%94%20100%25%20in%20B%26W.jpg',
],
......@@ -376,8 +384,8 @@ class FileUrlGeneratorTest extends UnitTestCase {
'//cdn.example.com/subdir/sites/default/files/llama%2520.jpg',
],
'reserved characters in RFC3986' => [
'public://gendelims :?#[]@ subdelims !$&\'()*+,;=.something',
'//cdn.example.com/subdir/sites/default/files/gendelims%20%3A%3F%23%5B%5D%40%20subdelims%20%21%24%26%27%28%29%2A%2B%2C%3B%3D.something',
'public://gen-delims :?#[]@ sub-delims !$&\'()*+,;=.something',
'//cdn.example.com/subdir/sites/default/files/gen-delims%20%3A%3F%23%5B%5D%40%20sub-delims%20%21%24%26%27%28%29%2A%2B%2C%3B%3D.something',
],
];
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment