Setup CI and run tests 10.2+ #3446118
Closes #3446118
Merge request reports
Activity
added 1 commit
- b544c1c2 - add default config and test to make sure login/logout forms are broken
@osab here's a test that fails on 11.x because login form is not accessible, it blocking testing of authorized user
added 1 commit
- 10e826ce - 3446118-add-basic-test fixing tests, updating descriptions
21 21 arguments: 22 22 - '@renderer_cache_review.inner' 23 23 - '@current_route_match' 24 - '@callable_resolver' 24 - '@controller_resolver' -
@andypost I had to return 'controller_resolver' here to fix error. As I extended Renderer in class RendererCacheReview and it needs 'controller_resolver in parent::__construct() call.
-
it means you need to have separate version for 10.2+
Other option is using service provider where you can check the core version and inject
-
We have 1.0.x, it is old version (before 10.2) and the branch 1.1.x for 10.2+. Could you clarify please, if I need to fix smth here? Thanks!
Edited by Oleg Sabadash -
checking 11.x and https://www.drupal.org/node/3368504
Moreover decorated renderer require
callable_resolveras since 10.2 it's "common API" to callables https://www.drupal.org/node/3353869renderer: class: Drupal\Core\Render\Renderer arguments: ['@callable_resolver', '@theme.manager', '@plugin.manager.element_info', '@render_placeholder_generator', '@render_cache', '@request_stack', '%renderer.config%'] -
and 1.0.x is using
controller_resolveras there was no the API before 10.2Edited by Andrey Postnikov changed this line in version 13 of the diff
14 14 /** 15 15 * {@inheritdoc} 16 16 */ 17 protected $defaultTheme = 'stark'; 17 protected $defaultTheme = 'olivero'; -
@andypost finally I've found that the problem was related to the src/StackMiddleware/CacheReview.php handle() function. There I add additional "Page cache status" description on the page. And I've found that tests works if I remove several sentences from that "Page cache status" section. It looks like limitation for "stark" theme.
-
@andypost I've added separate issue for this bug https://www.drupal.org/project/cache_review/issues/3464268
requested review from @andypost
added 1 commit
- 93c59d72 - 3446118-add-basic-test fixed phpcs/stylelint and improved test
assigned to @osab
added 1 commit
- 4bfec854 - 3446118-add-basic-test fixed phpcs, stylelint
added 1 commit
- 9daa7e28 - 3446118-add-basic-test fixed phpcs, stylelint, cspell
added 1 commit
- bd6bf4d0 - 3446118-add-basic-test replaced controller_resolver by callable_resolver according to core 11.x