Bootstrap Barrio Sass overriding css unnecessarily and in a bad way.
Closes #3392205
Merge request reports
Activity
10 10 -------------------------------------------------*/ 11 11 12 12 body { 13 background: $white; 13 background: $body-bg; -
Hi Ravi,
Thanks for looking into this.
While this is a step in the right direction I think this is the wrong approach. See bootstrap's typography.md file.
Use $body-bg to set a background-color on the
(#fff by default).https://github.com/twbs/bootstrap/blob/v5.3.2/site/content/docs/5.3/content/typography.md
also
In other words you probably should remove this all together as it is reinventing the wheel and causing unnecessary complexity. In my opinion it is better to work with the framework here.
Looking at bootstrap_barrio I can see you already have $body-bg: $white; already defined in variables.scss. This is probably also unnecessary as it also already defined in bootstrap's _variables.scss e.g.
$body-bg: $white !default; changed this line in version 2 of the diff
added 1 commit
- 75917659 - Bootstrap Barrio Sass overriding css unnecessarily and in a bad way.
added 1 commit
- ce04b08d - Bootstrap Barrio Sass overriding css unnecessarily and in a bad way.