Skip to content
Snippets Groups Projects
Commit abbce8ba authored by Gaus Surahman's avatar Gaus Surahman
Browse files

Issue #3364903 by SadySierralta, gausarts: W3C validation - Bad value for...

Issue #3364903 by SadySierralta, gausarts: W3C validation - Bad value for attribute srcset on element source
parent 90da1149
No related branches found
No related tags found
No related merge requests found
Blazy 8.x-2.0-dev, 2023-06-07
------------------------------
- Issue #3364903 by SadySierralta, gausarts: W3C validation - Bad value for
attribute srcset on element source.
Blazy 8.x-2.0-dev, 2023-06-02
------------------------------
- Fixed for D10 breaking changes with Blazy lightboxes within Views.
......
......@@ -7,13 +7,6 @@ namespace Drupal\blazy;
*/
interface BlazyInterface {
/**
* Defines constant placeholder Data URI image.
*
* @todo deprecated and removed for Placeholder::DATA anytime.
*/
const PLACEHOLDER = 'data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7';
/**
* Returns the app root.
*
......
......@@ -11,12 +11,22 @@ use Drupal\blazy\Blazy;
*/
class Placeholder {
/**
* Defines constant placeholder blank URL.
*/
const BLANK = 'about:blank';
/**
* Defines constant placeholder Data URI image.
*
* <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1 1"/>
*/
const DATA = 'data:image/svg+xml;charset=utf-8,%3Csvg%20xmlns%3D"http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg"%20viewBox%3D"0%200%201%201"%2F%3E';
const DATA = "data:image/svg+xml;charset=utf-8,%3Csvg%20xmlns%3D'http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg'%20viewBox%3D'0%200%201%201'%2F%3E";
/**
* Defines constant placeholder Data URI image.
*/
const GIF = 'data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7';
/**
* Build out the blur image.
......
......@@ -147,7 +147,7 @@ class BlazyTheme {
foreach ($files as $file) {
$source_attributes = &$file['source_attributes'];
$source_attributes->setAttribute('data-src', $source_attributes['src']->value());
$source_attributes->setAttribute('src', '');
$source_attributes->setAttribute('src', Placeholder::BLANK);
}
}
......@@ -194,7 +194,7 @@ class BlazyTheme {
/** @var \Drupal\Core\Template\Attribute $source */
foreach ((array) $sources as &$source) {
$source->setAttribute('data-srcset', $source['srcset']->value());
$source->setAttribute('srcset', '');
$source->setAttribute('srcset', Placeholder::BLANK);
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment