Skip to content
Snippets Groups Projects

Issue #3488491: Fix compatibility with date_filter module by adjusting...

Open Issue #3488491: Fix compatibility with date_filter module by adjusting...
issue/bef_date_filters-3488491:3488491-incompatibility-with-datefilter into 1.x
Open Jeyson Umaña requested to merge issue/bef_date_filters-3488491:3488491-incompatibility-with-datefilter into 1.x

Issue #3488491: Fix compatibility with date_filter module by adjusting isApplicable() and JS selectors.

This merge request fixes the compatibility issue between better_exposed_filters and the date_filter module when using the Year and Month Between filter.

Changes made: Updated isApplicable() in YearMonthBetween.php to check if the date_filter module is installed. If installed, it also validates against DateTime instead of Date. Adjusted the JavaScript in year-month-between.js to dynamically append -date to minDate and maxDate selectors when date_filter is enabled, ensuring the exposed filters work correctly. Why is this needed? Without this fix, when date_filter is installed:

The filter is not recognized as applicable due to the DateTime class change. The JavaScript selectors fail to update the correct fields, breaking the exposed filters functionality. This patch successfully solved the issue for me. :rocket: Let me know if any adjustments are needed!

Closes #3488491

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply