Skip to content
Snippets Groups Projects

Issue #3368741: Drush build test symlinks drush and only passes because it loads classes not in build test project

Merged Issue #3368741: Drush build test symlinks drush and only passes because it loads classes not in build test project
3 unresolved threads
3 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
402 402 public function testDrushUpdate(): void {
403 403 $this->createTestProject('RecommendedProject');
404 404
405 $this->runComposer('composer require drush/drush', 'project');
405 $output = $this->runComposer('COMPOSER_MIRROR_PATH_REPOS=1 composer require drush/drush', 'project');
406 $this->assertStringNotContainsString('Symlinking', $output);
  • Comment on lines -405 to +406
    Author Maintainer

    I think just this change will make the test fail because drush/drush dependencies will not be available. At least that is what is happening to me locally.

  • Please register or sign in to reply
  • Ted Bowman added 2 commits

    added 2 commits

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Adam G-H
  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • 439 439 ];
    440 if (isset($package_info['require'])) {
    441 unset(
    442 $package_info['require']['symfony/polyfill-php73'],
    443 $package_info['require']['symfony/polyfill-php74'],
    444 $package_info['require']['symfony/polyfill-php80'],
    445 $package_info['require']['symfony/polyfill-php81'],
    446 );
    447 $packages[$name][$version]['require'] = $package_info['require'];
    448 }
    440 449 // Composer plugins are loaded and activated as early as possible, and
    441 450 // they must have a `class` key defined in their `extra` section, along
    442 451 // with a dependency on `composer-plugin-api` (plus any other real
    443 452 // runtime dependencies).
    444 453 if ($packages[$name][$version]['type'] === 'composer-plugin') {
    445 454 $packages[$name][$version]['require'] = $package_info['require'] ?? [];
  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman
    Ted Bowman @tedbow started a thread on the diff
  • 279 279 $this->runComposer('composer require --no-update drupal/core-vendor-hardening:*', $template_dir);
    280 280 }
    281 281
    282 // Do not run developement Composer plugin.
    283 $this->runComposer("composer config allow-plugins.dealerdirect/phpcodesniffer-composer-installer false", $template_dir);
    • Author Maintainer

      I found locally when ran the build test with create-project using --verbose that on 10.0.9 other 10.0.x version it was trying to run this plugin. I can't see why we would need this to run in our build test.

    • Please register or sign in to reply
  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Adam G-H added 12 commits

    added 12 commits

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading