Skip to content
Snippets Groups Projects

Issue #3362746: fix 10.0.x phpstan errors

3 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
133 133 $this->assertModuleVersion('alpha', '1.1.0');
134 134 }
135 135
136 /**
137 * {@inheritdoc}
138 */
139 public function copyCodebase(\Iterator $iterator = NULL, $working_dir = NULL): void {
140 parent::copyCodebase($iterator, $working_dir);
141
142 // Ensure that we will install Drupal 9.8.0 (a fake version that should
143 // never exist in real life) initially.
144 $this->setUpstreamCoreVersion('9.8.0');
  • Author Maintainer

    what was happening was that this test did not have core version set. So if it is a dev branch the update module will not try to find the security updates but if you are on are particular version like we have to test for 10.0.7 then it will try to find the security update. So need to ensure the right version that matches with the update XML fixture so the update module will not report core needs a security update.

  • Please register or sign in to reply
  • Ted Bowman
    Ted Bowman @tedbow started a thread on the diff
  • 24 24 protected function createTestProject(string $template): void {
    25 25 parent::createTestProject($template);
    26 26 $this->setReleaseMetadata([
    27 'drupal' => __DIR__ . '/../../../../package_manager/tests/fixtures/release-history/drupal.9.8.1-security.xml',
    27 'drupal' => __DIR__ . '/../../../../package_manager/tests/fixtures/release-history/drupal.9.8.2.xml',
  • Ted Bowman
    Ted Bowman @tedbow started a thread on the diff
  • 92 92 * The Symfony filesystem class.
    93 93 *
    94 94 * @var \Symfony\Component\Filesystem\Filesystem
    95 * @phpstan-ignore-next-line
  • merged

  • Please register or sign in to reply
    Loading