Skip to content
Snippets Groups Projects

Issue #3341224: Always catch \Throwable, not \Exception and always pass the old exception when re-throwing.

Merged Issue #3341224: Always catch \Throwable, not \Exception and always pass the old exception when re-throwing.
issue/automatic_updates-3341224:3341224-always-catch-throwable-30x into 3.0.x
All threads resolved!
Merged omkar podey requested to merge issue/automatic_updates-3341224:3341224-always-catch-throwable-30x into 3.0.x
All threads resolved!
Viewing commit f9b4d3e7
Prev Next
Show latest version
1 file
+ 2
− 1
Compare changes
  • Side-by-side
  • Inline
drupalci.yml
+ 2
− 1
@@ -36,6 +36,8 @@ build:
- cat modules/contrib/automatic_updates/dictionary.txt >> core/misc/cspell/dictionary.txt
# Ensure we have the full path to PHPStan.
- sed -i "s/vendor\/bin\/phpstan/\/var\/www\/html\/vendor\/bin\/phpstan/" modules/contrib/automatic_updates/commit-code-check.sh
# Ensure that debugging commit-code-check.sh is feasible at all times.
- sed -i "s/# Searches an array./set -xev/" modules/contrib/automatic_updates/commit-code-check.sh
# After all of the shenanigans above, we're finally ready to run core's `commit-code-check.sh`! :)
- cat modules/contrib/automatic_updates/commit-code-check.sh
- diff /var/www/html/core/scripts/dev/commit-code-check.sh modules/contrib/automatic_updates/commit-code-check.sh
@@ -43,7 +45,6 @@ build:
- ls -al modules/contrib/automatic_updates/src/
- ls -al /var/www/html/core/
- git config --global --add safe.directory /var/www/html/modules/contrib/automatic_updates
- sh -xev modules/contrib/automatic_updates/commit-code-check.sh --drupalci
# Restore the original permissions.
- chmod 777 modules/contrib/automatic_updates/
# Disable the PCRE engine's JIT, since it causes Composer to die during the