Issue #3257134: Don't stage node_modules directories

package_manager/src/PathExcluder/NodeModuleExcluder.php

+<?php
+
+namespace Drupal\package_manager\PathExcluder;
+
+use Drupal\package_manager\Event\PreApplyEvent;
+use Drupal\package_manager\Event\PreCreateEvent;
+use Drupal\package_manager\Event\StageEvent;
+use Drupal\package_manager\PathLocator;
+use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+use Symfony\Component\Finder\Finder;
+
+/**
+ * Excludes node_modules files from staging areas.
+ *
+ * @internal
+ *   This is an internal part of Package Manager and may be changed or removed
+ *   at any time without warning. External code should not interact with this
+ *   class.
+ */
+class NodeModuleExcluder implements EventSubscriberInterface {
+
+  use PathExclusionsTrait;
+
+  /**
+   * Constructs an ExcludedPathsSubscriber.
+   *
+   * @param \Drupal\package_manager\PathLocator $path_locator
+   *   The path locator service.
+   */
+  public function __construct(PathLocator $path_locator) {
+    $this->pathLocator = $path_locator;
+  }
+
+  /**
+   * Excludes node_modules directory from staging operations.
+   *
+   * @param \Drupal\package_manager\Event\PreApplyEvent|\Drupal\package_manager\Event\PreCreateEvent $event
+   *   The event object.
+   *
+   * @see \Drupal\package_manager\Event\ExcludedPathsTrait::excludePath()
+   */
+  public function excludeNodeModulesFiles(StageEvent $event): void {
+    $finder = Finder::create()
+      ->in($this->pathLocator->getProjectRoot())
+      ->directories()
+      ->name('.git')
+      ->name(['.git', 'node_modules'])
+      ->ignoreVCS(FALSE)
+      ->ignoreDotFiles(FALSE);
+    $paths = [];
+    foreach ($finder as $directory) {
+      $paths[] = $directory->getPathname();
+    }
+    $this->excludeInProjectRoot($event, $paths);
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public static function getSubscribedEvents() {
+    return [
+      PreCreateEvent::class => 'excludeNodeModulesFiles',
+      PreApplyEvent::class => 'excludeNodeModulesFiles',
+    ];
+  }
+
+}

[Adam G-H]

Let's call this NodeModulesExcluder (plural on "modules").

[Yash Rode]

done

[Ted Bowman]

Wrong class name

[Yash Rode]

renamed.

[Adam G-H]

Is there a reason we're calling name() twice and passing .git?

[Yash Rode]

No it was copy paste left over, removed now.