Issue #3298889: Make \Drupal\package_manager_test_api\ApiController more easily extendable
Merged
requested to merge issue/automatic_updates-3298889:3298889-make-drupalpackagemanagertestapiapicontroller-more into 8.x-2.x
1 unresolved thread
Merge request reports
Activity
added 2 commits
added 6 commits
-
ddd1075a...6c5f1e62 - 2 commits from branch
project:8.x-2.x
- 54473620 - Refactored PackageMangerTestApi
- 8c68e544 - added routing
- eaabd40a - progress
- eafb821d - Changed TestController to use package manager run
Toggle commit list-
ddd1075a...6c5f1e62 - 2 commits from branch
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
added 13 commits
-
60d4a21b...928d9ef9 - 5 commits from branch
project:8.x-2.x
- f0b63b24 - Refactored PackageMangerTestApi
- dd2f4f51 - added routing
- 57ed9269 - progress
- 2f0703ad - Changed TestController to use package manager run
- 692587da - chnaged for legacy project to pass tests
- febf2d98 - nitpicks
- 4403c35b - test error
- 9feb0833 - Renamed TestController
Toggle commit list-
60d4a21b...928d9ef9 - 5 commits from branch
added 1 commit
- 1cfcb442 - installed package_manager_test_api for AutomaticUpdatesFunctionalTestBase
- Resolved by Adam G-H
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
added 20 commits
-
1cfcb442...29927706 - 7 commits from branch
project:8.x-2.x
- 960ac634 - Refactored PackageMangerTestApi
- 400b7751 - added routing
- 24b18287 - progress
- 93eb9c7b - Changed TestController to use package manager run
- 5d918a72 - chnaged for legacy project to pass tests
- 444e6482 - nitpicks
- f612f895 - test error
- ad92b84c - Renamed TestController
- 70f0fe5d - added doc comment for testApi()
- cb71ae39 - Renamed routes
- d5e03200 - Installed package_manager_test_api
- eb2862c7 - installed package_manager_test_api for AutomaticUpdatesFunctionalTestBase
- 3dc4eafc - nitpicks
Toggle commit list-
1cfcb442...29927706 - 7 commits from branch
added 1 commit
- 84c0c424 - testing if we need a package_manager_test_api to be installed
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
added 19 commits
-
315e4f36...5474065a - 2 commits from branch
project:8.x-2.x
- 6b995a3d - Refactored PackageMangerTestApi
- 2528d807 - added routing
- 297c6cf1 - progress
- cbcd4682 - Changed TestController to use package manager run
- 3b54271d - chnaged for legacy project to pass tests
- 103a7ebc - nitpicks
- 9e8fdaa7 - test error
- b6a75de6 - Renamed TestController
- 8885006c - added doc comment for testApi()
- e600449d - Renamed routes
- bf5467e6 - Installed package_manager_test_api
- 923dd1ad - installed package_manager_test_api for AutomaticUpdatesFunctionalTestBase
- de1b4390 - nitpicks
- 055673c3 - testing if we need a package_manager_test_api to be installed
- c3ac543c - restored last commit
- 6f142dab - phenaproxima suggestions
- a676f911 - nitpicks exclude package_manager_test_api installation
Toggle commit list-
315e4f36...5474065a - 2 commits from branch
added 1 commit
- d1f005b8 - created automatic_updates_test-api and refactored
- Resolved by Adam G-H
- Resolved by Ted Bowman
- Resolved by Ted Bowman
added 20 commits
-
ddc9ddf5 - 1 commit from branch
project:8.x-2.x
- fa929ba2 - Refactored PackageMangerTestApi
- 57875322 - added routing
- 3aa6892b - progress
- 853cc0be - Changed TestController to use package manager run
- adaf54e1 - chnaged for legacy project to pass tests
- 0d6681f2 - nitpicks
- 0b4d0eb9 - test error
- 333be47b - Renamed TestController
- f6cccdc4 - added doc comment for testApi()
- 088b1554 - Renamed routes
- 2f7bb14c - Installed package_manager_test_api
- 17e1f43e - installed package_manager_test_api for AutomaticUpdatesFunctionalTestBase
- a21ed6c7 - nitpicks
- d7fa4d54 - testing if we need a package_manager_test_api to be installed
- 30cd1637 - restored last commit
- fede248a - phenaproxima suggestions
- f908416a - nitpicks exclude package_manager_test_api installation
- 0c89a4ee - created automatic_updates_test-api and refactored
- b614a4e2 - test nits
Toggle commit list-
ddc9ddf5 - 1 commit from branch
18 * {@inheritdoc} 19 */ 20 public static function create(ContainerInterface $container) { 21 return new static( 22 $container->get('automatic_updates.updater'), 23 $container->get('package_manager.path_locator') 24 ); 25 } 26 27 /** 28 * {@inheritdoc} 29 */ 30 protected function createAndApplyStage(Request $request): string { 31 // @todo https://www.drupal.org/project/automatic_updates/issues/3315700 32 // Let it take as long as it needs. 33 Environment::setTimeLimit(0); - Comment on lines +31 to +33
we just actually just removed this and merged https://www.drupal.org/project/automatic_updates/issues/3315700
Can you remove the setTimeLimit and the comment
changed this line in version 18 of the diff
added 20 commits
-
451a7c34 - 1 commit from branch
project:8.x-2.x
- fea46f95 - Refactored PackageMangerTestApi
- fa4a51d0 - added routing
- 93d96e39 - progress
- bba43c14 - Changed TestController to use package manager run
- 0d0552b3 - chnaged for legacy project to pass tests
- 31505658 - nitpicks
- 71216b59 - test error
- 6a4f0c5f - Renamed TestController
- fe535424 - added doc comment for testApi()
- e742c960 - Renamed routes
- a57b34a2 - Installed package_manager_test_api
- 5aacdff7 - installed package_manager_test_api for AutomaticUpdatesFunctionalTestBase
- bca636a1 - nitpicks
- 0b68a35b - testing if we need a package_manager_test_api to be installed
- d7ca0287 - restored last commit
- 0ff77655 - phenaproxima suggestions
- bc167224 - nitpicks exclude package_manager_test_api installation
- 242ffa6b - created automatic_updates_test-api and refactored
- e7e94235 - test nits
Toggle commit list-
451a7c34 - 1 commit from branch
Please register or sign in to reply