Skip to content
Snippets Groups Projects

Issue #3298889: Make \Drupal\package_manager_test_api\ApiController more easily extendable

Merged Issue #3298889: Make \Drupal\package_manager_test_api\ApiController more easily extendable
1 unresolved thread
1 unresolved thread

Merge request reports

Merged by Ted BowmanTed Bowman 2 years ago (Oct 21, 2022 2:57pm UTC)

Merge details

  • Changes merged into 8.x-2.x with 5a0110c4 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ted Bowman
  • Ted Bowman
  • Ted Bowman
  • Ted Bowman
  • Ted Bowman
  • Ted Bowman
  • Yash Rode added 1 commit

    added 1 commit

    • bc8fe679 - chnaged for legacy project to pass tests

    Compare with previous version

  • Yash Rode added 2 commits

    added 2 commits

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    Compare with previous version

  • Yash Rode added 13 commits

    added 13 commits

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    • 6f018fd3 - added doc comment for testApi()

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    • 1669c40f - Installed package_manager_test_api

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    • 1cfcb442 - installed package_manager_test_api for AutomaticUpdatesFunctionalTestBase

    Compare with previous version

  • Ted Bowman
  • Ted Bowman
  • Ted Bowman
  • Ted Bowman
  • Yash Rode added 20 commits

    added 20 commits

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    • 84c0c424 - testing if we need a package_manager_test_api to be installed

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    Compare with previous version

  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Yash Rode added 19 commits

    added 19 commits

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    • d1f005b8 - created automatic_updates_test-api and refactored

    Compare with previous version

  • Adam G-H
  • Adam G-H
  • A few small things but otherwise I think this is looking excellent.

  • Adam G-H
  • Yash Rode added 20 commits

    added 20 commits

    • ddc9ddf5 - 1 commit from branch project:8.x-2.x
    • fa929ba2 - Refactored PackageMangerTestApi
    • 57875322 - added routing
    • 3aa6892b - progress
    • 853cc0be - Changed TestController to use package manager run
    • adaf54e1 - chnaged for legacy project to pass tests
    • 0d6681f2 - nitpicks
    • 0b4d0eb9 - test error
    • 333be47b - Renamed TestController
    • f6cccdc4 - added doc comment for testApi()
    • 088b1554 - Renamed routes
    • 2f7bb14c - Installed package_manager_test_api
    • 17e1f43e - installed package_manager_test_api for AutomaticUpdatesFunctionalTestBase
    • a21ed6c7 - nitpicks
    • d7fa4d54 - testing if we need a package_manager_test_api to be installed
    • 30cd1637 - restored last commit
    • fede248a - phenaproxima suggestions
    • f908416a - nitpicks exclude package_manager_test_api installation
    • 0c89a4ee - created automatic_updates_test-api and refactored
    • b614a4e2 - test nits

    Compare with previous version

  • 18 * {@inheritdoc}
    19 */
    20 public static function create(ContainerInterface $container) {
    21 return new static(
    22 $container->get('automatic_updates.updater'),
    23 $container->get('package_manager.path_locator')
    24 );
    25 }
    26
    27 /**
    28 * {@inheritdoc}
    29 */
    30 protected function createAndApplyStage(Request $request): string {
    31 // @todo https://www.drupal.org/project/automatic_updates/issues/3315700
    32 // Let it take as long as it needs.
    33 Environment::setTimeLimit(0);
  • Yash Rode added 20 commits

    added 20 commits

    • 451a7c34 - 1 commit from branch project:8.x-2.x
    • fea46f95 - Refactored PackageMangerTestApi
    • fa4a51d0 - added routing
    • 93d96e39 - progress
    • bba43c14 - Changed TestController to use package manager run
    • 0d0552b3 - chnaged for legacy project to pass tests
    • 31505658 - nitpicks
    • 71216b59 - test error
    • 6a4f0c5f - Renamed TestController
    • fe535424 - added doc comment for testApi()
    • e742c960 - Renamed routes
    • a57b34a2 - Installed package_manager_test_api
    • 5aacdff7 - installed package_manager_test_api for AutomaticUpdatesFunctionalTestBase
    • bca636a1 - nitpicks
    • 0b68a35b - testing if we need a package_manager_test_api to be installed
    • d7ca0287 - restored last commit
    • 0ff77655 - phenaproxima suggestions
    • bc167224 - nitpicks exclude package_manager_test_api installation
    • 242ffa6b - created automatic_updates_test-api and refactored
    • e7e94235 - test nits

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading