Skip to content
Snippets Groups Projects

Issue #3276645: Run readiness checks after stored results have been cleared in certain situations

Merged Issue #3276645: Run readiness checks after stored results have been cleared in certain situations
2 unresolved threads
2 unresolved threads

Merge request reports

Merged results pipeline #8109 skipped

Merged results pipeline skipped for eec5413b

Merged by Ted BowmanTed Bowman 2 years ago (Nov 15, 2022 11:25pm UTC)

Merge details

  • Changes merged into 8.x-2.x with 77ea670b (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yash Rode added 20 commits

    added 20 commits

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    • d1907ae7 - use StatusCheck instead of ReadinessCheck

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 4 commits

    added 4 commits

    • 9ff0e3c8...5474065a - 2 commits from branch project:8.x-2.x
    • 72cdb464 - Merge branch '8.x-2.x' into 3276645-run-readiness-checks
    • 71eb508b - Revert "revert to fix in PostApply"

    Compare with previous version

  • Ted Bowman
  • Ted Bowman
  • Yash Rode added 1 commit

    added 1 commit

    Compare with previous version

  • Yash Rode added 8 commits

    added 8 commits

    Compare with previous version

  • Adam G-H
  • Yash Rode added 10 commits

    added 10 commits

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman
  • Ted Bowman
  • Ted Bowman added 16 commits

    added 16 commits

    • 30fef251...0bcd417a - 13 commits from branch project:8.x-2.x
    • b907bc77 - add comments to testStatusCheckerRunAfterUpdate
    • 055467aa - Merge branch '8.x-2.x' into 3276645-run-readiness-checks
    • ab270da6 - Remove unneeded change to test

    Compare with previous version

  • Ted Bowman
  • Ted Bowman
  • Yash Rode added 1 commit

    added 1 commit

    • ea8a270a - modified test to check with and without database updates

    Compare with previous version

  • Yash Rode added 15 commits

    added 15 commits

    Compare with previous version

  • Wim Leers
  • Yash Rode added 1 commit

    added 1 commit

    • 73fdc4a9 - moved StatusCheck run call before if else.

    Compare with previous version

  • Yash Rode added 18 commits

    added 18 commits

    Compare with previous version

  • Ted Bowman
  • Yash Rode added 2 commits

    added 2 commits

    • 6abe18c6 - Added testStatusCheckerRunAfterUpdate
    • f9eefbe2 - completed test in case of databse updates.

    Compare with previous version

  • Yash Rode added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Yash Rode added 22 commits

    added 22 commits

    Compare with previous version

  • Yash Rode added 1 commit
  • 749 $this->checkForUpdates();
    750 $page = $this->getSession()->getPage();
    751 // Navigate to the automatic updates form.
    752 $this->drupalGet('/admin/modules/update');
    753 Stager::setFixturePath(__DIR__ . '/../../fixtures/drupal-9.8.1-installed');
    754 $page->pressButton('Update to 9.8.1');
    755 $this->checkForMetaRefresh();
    756 $this->assertUpdateStagedTimes(1);
    757 $this->assertUpdateReady('9.8.1');
    758 // Set an error before completing the update. This error should be visible
    759 // on admin pages after completing the update without having to explicitly
    760 // run the status checks.
    761 TestSubscriber1::setTestResult([ValidationResult::createError(['Error before continue.'])], StatusCheckEvent::class);
    762 if ($has_database_updates) {
    763 // Simulate a staged database update in the automatic_updates_test module.
    764 // We must do this after the update has started, because the pending updates
  • Ted Bowman
  • 273 $assert_session->pageTextContains('Dynamic automatic_updates_update_1191934');
    274 $page->clickLink('Apply pending updates');
    275 $this->checkForMetaRefresh();
    276 $assert_session->pageTextContains('Updates were attempted.');
    277 }
    278 else {
    279 $page->pressButton('Continue');
    280 $this->checkForMetaRefresh();
    281 $assert_session->addressEquals('/admin/reports/updates');
    282 $assert_session->pageTextContainsOnce('Update complete!');
    283 }
    284 // Status checks should display errors on admin page.
    285 $this->drupalGet('/admin');
    286 // Confirm that the status checks were run and the new error is displayed.
    287 $assert_session->pageTextContains('Error before continue.');
    288 $assert_session->pageTextContains(static::$errorsExplanation);
  • Ted Bowman added 2 commits

    added 2 commits

    • 568bcbfb - comment line length
    • 1ba580ef - comment lenght and use statusMessageContains

    Compare with previous version

  • Ted Bowman added 33 commits

    added 33 commits

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading