2 unresolved threads
Merge request reports
Activity
added 1 commit
- 3659fa4b - Added test coverage to check the package manager help link is clickable
added 6 commits
-
3659fa4b...901dcd37 - 5 commits from branch
project:8.x-2.x
- 9f5cc04b - Merge branch '8.x-2.x' into 3275991-write-test-coverage
-
3659fa4b...901dcd37 - 5 commits from branch
added 52 commits
-
30d805b1...0d934d20 - 49 commits from branch
project:8.x-2.x
- 796a3e91 - Added test coverage to check the package manager help link is clickable
- bedd7077 - Fix the markup handling in the validator
- af5d54aa - Removed debug
Toggle commit list-
30d805b1...0d934d20 - 49 commits from branch
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
added 8 commits
-
18d1ca72 - 1 commit from branch
project:8.x-2.x
- a0f8c032 - Added test coverage to check the package manager help link is clickable
- 4af53c09 - Fix the markup handling in the validator
- c2aae33d - Removed debug
- 1c1a2e22 - cspell error
- 4b106a9e - Repalced readiness check with status check.
- 126dbda5 - modified test coverage
- 3940754a - nit picks
Toggle commit list-
18d1ca72 - 1 commit from branch
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- Resolved by Ted Bowman
- tests/src/Functional/ClickableHelpTest.php 0 → 100644
5 /** 6 * Tests package manager help link is clickable. 7 * 8 * @group automatic_updates 9 */ 10 class ClickableHelpTest extends AutomaticUpdatesFunctionalTestBase { 11 12 /** 13 * {@inheritdoc} 14 */ 15 protected static $modules = ['automatic_updates', 'help']; 16 17 /** 18 * {@inheritdoc} 19 */ 20 protected $defaultTheme = 'stark'; changed this line in version 11 of the diff
@wimleers the rest of our tests have
stark
should we open up an issue to change them all?
- Resolved by Ted Bowman
added 15 commits
-
b918ae17...6bf619d5 - 6 commits from branch
project:8.x-2.x
- 7b30919a - Added test coverage to check the package manager help link is clickable
- 4266f548 - Fix the markup handling in the validator
- a205f902 - Removed debug
- d97a0628 - cspell error
- 5cb698b3 - Repalced readiness check with status check.
- c4c3cd65 - modified test coverage
- 93240b41 - nit picks
- ff0a43fc - re-enabled validator
- 638b30cd - nits
Toggle commit list-
b918ae17...6bf619d5 - 6 commits from branch
- tests/src/Functional/ClickableHelpTest.php 0 → 100644
25 protected $defaultTheme = 'starterkit_theme'; 26 27 /** 28 * {@inheritdoc} 29 */ 30 protected function setUp(): void { 31 unset($this->disableValidators[array_search('package_manager.validator.composer_executable', $this->disableValidators)]); 32 parent::setUp(); 33 $this->setReleaseMetadata(__DIR__ . '/../../../package_manager/tests/fixtures/release-history/drupal.9.8.1-security.xml'); 34 $this->checkerRunnerUser = $this->createUser([ 35 'administer site configuration', 36 ]); 37 } 38 39 /** 40 * Tests if composer executable is not present then the help link in error is clickable. @wimleers this is over 80 chars but maybe that rule has been relaxed?
changed this line in version 12 of the diff
Green, so … all done here
IIRC the 80 col rule is not applied strictly to
*Test.php
files?Edited by Wim Leers
added 11 commits
-
fb6d0d7f - 1 commit from branch
project:8.x-2.x
- 760e168d - Added test coverage to check the package manager help link is clickable
- 7942d83c - Fix the markup handling in the validator
- efec2c28 - Removed debug
- 489bf6c1 - cspell error
- 75c88849 - Repalced readiness check with status check.
- f14328a8 - modified test coverage
- d77beb6e - nit picks
- e6c0155d - re-enabled validator
- ea8109f7 - nits
- f074c4c5 - Comment longer than 80 chars
Toggle commit list-
fb6d0d7f - 1 commit from branch
Please register or sign in to reply