Issue #3303929: Never allow updating to an un-installable version
Merge request reports
Activity
added 5 commits
-
328a5a09...ee2a3669 - 5 commits from branch
project:8.x-2.x
-
328a5a09...ee2a3669 - 5 commits from branch
added 1 commit
- 93b48761 - created new directory for au ext tests and added test to modules variable
1 automatic_updates_extensions_tests: changed this line in version 4 of the diff
4 * @file 5 * Contains hook implementation for Automatic Updates Extensions. 6 */ 7 8 use Drupal\update\UpdateFetcherInterface; 9 10 /** 11 * Alter the information about available updates for projects. 12 * 13 * @param $projects 14 * Reference to an array of information about available updates to each 15 * project installed on the system. 16 * 17 * @see update_calculate_project_data() 18 */ 19 function automatic_updates_update_status_alter(&$projects) { -
This function name is wrong for implementing the hook.
since your info.yml file is
automatic_updates_extensions_test_update.info.ymlthe machine name of your module isautomatic_updates_extensions_test_updateso you would implement
hook_update_status_alterby creating the functionautomatic_updates_extensions_test_update_update_status_alterbasicallymachine_name_of_module+ (name of hook without "hook_"So in this case:
automatic_updates_extensions_test+update_status_alter=automatic_updates_extensions_test_update_update_status_alterhooks are weird.
The code may be working now but that is only because you are using the machine of another module
automatic_updatesso it only works becauseautomatic_updatesis not implementinghook_update_status_alterand if it did this code would break.Edited by Ted Bowman changed this line in version 5 of the diff
1 name: 'Automatic Updates Extensions Tests' changed this line in version 8 of the diff
3 /** 4 * @file 5 * Contains hook implementation for Automatic Updates Extensions. 6 */ 7 8 /** 9 * Alter the information about available updates for projects. 10 * 11 * @param $projects 12 * Reference to an array of information about available updates to each 13 * project installed on the system. 14 * 15 * @see update_calculate_project_data() 16 */ 17 function automatic_updates_extensions_test_update_update_status_alter(&$projects) { 18 if (!empty($projects['semver_test'])) { -
The fact that our tests are failing means that this is changing the recommended version which is good. But we only want to do this in the new test method
testUninstallableReleaseruns.So we need to set a state flag to only do this when
testUninstallableReleaserunsSo at the first of
\Drupal\Tests\automatic_updates_extensions\Functional\UpdaterFormTest::testUninstallableRelease()add$this->container->get('state')->set('testUninstallableRelease', TRUE);then here change this to
This way this will only check affect the 1 test.
then at the end of
testUninstallableReleaseinstead of assert the update is available do$this->assertNoUpdates();This should fail now proving the current bug but then we update
\Drupal\automatic_updates_extensions\Form\UpdaterForm::getRecommendedModuleUpdatesto make the sure the recommended release is in\Drupal\automatic_updates\ProjectInfo::getInstallableReleaseswhich fix the bug it will start to pass again. changed this line in version 8 of the diff
1 <?php 2 3 /** 4 * @file 5 * Contains hook implementation for Automatic Updates Extensions. changed this line in version 12 of the diff
431 /** 432 * Tests the form when an uninstallable module requires an update. 433 */ 434 public function testUninstallableRelease(): void { 435 $this->container->get('state')->set('testUninstallableRelease', TRUE); 436 $this->setReleaseMetadata(__DIR__ . '/../../fixtures/release-history/semver_test.1.1.xml'); 437 $assert = $this->assertSession(); 438 $this->setProjectInstalledVersion(['semver_test' => '8.1.0']); 439 $user = $this->createUser(['administer software updates', 'administer site configuration']); 440 $this->drupalLogin($user); 441 $this->drupalGet('admin/reports/updates/automatic-update-extensions'); 442 $this->checkForUpdates(); 443 $this->assertTableShowsUpdates('Semver Test', '8.1.0', '8.1.1'); 444 $this->assertUpdatesCount(1); 445 $assert->pageTextContains('Automatic Updates Form'); 446 $assert->buttonExists('Update'); changed this line in version 12 of the diff