Skip to content
Snippets Groups Projects

Issue #3285145: CronFrequencyValidatorTest should use a virtual project

Merged Issue #3285145: CronFrequencyValidatorTest should use a virtual project
1 unresolved thread
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
25 25 * {@inheritdoc}
26 26 */
27 27 protected function setUp(): void {
28 // Disable the symlink validator so that the test isn't affected by symlinks
29 // or other unexpected things that might be present in the running code
30 // base.
31 // @todo Make this test use a virtual project in
32 // https://drupal.org/i/3285145.
33 $this->disableValidators[] = 'automatic_updates.validator.symlink';
34 $this->disableValidators[] = 'package_manager.validator.symlink';
35 28 parent::setUp();
29 $this->createTestProject();
30 // Since we're using a virtual project, and the staging area will be created
31 // in the virtual file system, we don't need to bypass Package Manager.
32 $this->disableModules(['package_manager_bypass']);
  • Should other Kernel tests be disabling this?

  • Author Maintainer

    I wish I knew.

    Something very, very strange is going on and the update system (in core) is borderline impossible to parse with its queues and stuff.

    This call to disableModules() somehow circumvents it, but I don't know why.

  • I looked into this a little. I tried disabling another module to just see if any module would work but it didn't

    I pushed up another MR !354 (closed) with a different fix. Calling update_get_available(TRUE); in setUp() which kind of makes sense for the errors I was seeing and calling $this->container->get('state')->resetCache();. will explain on other PR

  • FWIW I tried this test on 9.3.sx without this line and it still failed. wanted to see if it was some core change

  • Adam G-H changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • Please register or sign in to reply
  • Adam G-H added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading