Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
automatic_updates
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
automatic_updates
Merge requests
!339
Issue
#3285631
: Make it impossible to call CronUpdater::begin() directly
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Issue
#3285631
: Make it impossible to call CronUpdater::begin() directly
issue/automatic_updates-3285631:3285631-make-it-impossible
into
8.x-2.x
Overview
11
Commits
12
Pipelines
0
Changes
1
All threads resolved!
Show all comments
Merged
Theresa Grannum
requested to merge
issue/automatic_updates-3285631:3285631-make-it-impossible
into
8.x-2.x
2 years ago
Overview
11
Commits
12
Pipelines
0
Changes
1
All threads resolved!
Show all comments
Expand
0
0
Merge request reports
Viewing commit
b468744d
Prev
Next
Show latest version
1 file
+
1
−
7
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
b468744d
No wire hangers ever.
· b468744d
Theresa Grannum
authored
2 years ago
src/CronUpdater.php
+
1
−
7
Options
@@ -97,13 +97,7 @@ class CronUpdater extends Updater {
* {@inheritdoc}
*/
final
public
function
begin
(
array
$project_versions
,
?int
$timeout
=
300
):
string
{
// Prevent mischievous callers from starting an update even if unattended
// updates are disabled. To start an update programmatically, use
// \Drupal\automatic_updates\Updater::begin().
if
(
$this
->
getMode
()
===
static
::
DISABLED
)
{
throw
new
\BadMethodCallException
(
__METHOD__
.
'() cannot be called directly.'
);
}
return
parent
::
begin
(
$project_versions
,
$timeout
);
throw
new
\BadMethodCallException
(
$project_versions
,
$timeout
);
}
/**
Loading