Skip to content
Snippets Groups Projects

Issue #3276662: Add test coverage for the fix in #3276661

Merged Issue #3276662: Add test coverage for the fix in #3276661
issue/automatic_updates-3276662:3276662-add-test-coverage into 8.x-2.x
1 unresolved thread
Merged Kunal Sachdev requested to merge issue/automatic_updates-3276662:3276662-add-test-coverage into 8.x-2.x
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Kunal Sachdev added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman resolved all threads

    resolved all threads

  • Ted Bowman
    Ted Bowman @tedbow started a thread on the diff
    • tests/src/Kernel/ReadinessValidation/CronUpdateVersionValidatorTest.php 0 → 100644
    1 <?php
    2
    3 namespace Drupal\Tests\automatic_updates\Kernel\ReadinessValidation;
    4
    5 use Drupal\automatic_updates\CronUpdater;
    6 use Drupal\package_manager\ValidationResult;
    7 use Drupal\Tests\automatic_updates\Kernel\AutomaticUpdatesKernelTestBase;
    8 use Drupal\Tests\package_manager\Traits\PackageManagerBypassTestTrait;
    9
    10 /**
    11 * @covers \Drupal\automatic_updates\Validator\CronUpdateVersionValidator
    12 *
    13 * @group automatic_updates
    14 */
    15 class CronUpdateVersionValidatorTest extends AutomaticUpdatesKernelTestBase {
    • Ted Bowman
      Ted Bowman @tedbow ·
      Maintainer

      I am glad we have this new test class. I suspect that UpdateVersionValidatorTest in some methods is only testing logic that happens in CronUpdateVersionValidator should make a follow up to more of these methods to the new class?

    • Please register or sign in to reply
  • Ted Bowman merged

    merged

    • Please register or sign in to reply