Skip to content
Snippets Groups Projects

Issue #3274633: Move semver test to new directory

2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
19 19 public function metadata($project_name = 'drupal', $version = NULL): Response {
20 20 $xml_map = $this->config('update_test.settings')->get('xml_map');
21 21 if (isset($xml_map[$project_name])) {
22 $availability_scenario = $xml_map[$project_name];
22 $file = $xml_map[$project_name];
  • This entire controller is copypasta from Drupal core, so in theory we shouldn't change anything in it, but really, $availability_scenario is such an incomprehensible name for this variable that I have no objections. No action needed here, just sharing my thoughts.

  • Please register or sign in to reply
  • 135 135 ->set('fetch.url', $this->baseUrl . '/test-release-history')
    136 136 ->save();
    137 137
    138 [$project, $fixture] = explode('.', basename($file, '.xml'), 2);
    138 [$project] = explode('.', basename($file, '.xml'), 2);
    • I'm surprised this change hasn't broken more tests. This is not blocking feedback; I just want to understand the nature of this change and why it was made. Let's discuss in post-scrum. (No action needed on this point right now.)

    • Please register or sign in to reply
  • merged

  • Please register or sign in to reply
    Loading