Issue #3267577: Clean up in hook_uninstall
Merge request reports
Activity
added 6 commits
-
071311bb...9ae97d18 - 5 commits from branch
project:8.x-2.x - 2233b73d - Merge branch '8.x-2.x' into 3267577-clean--up
-
071311bb...9ae97d18 - 5 commits from branch
23 $this->container->get('config.factory'), 24 $this->container->get('package_manager.path_locator'), 25 $this->container->get('package_manager.beginner'), 26 $this->container->get('package_manager.stager'), 27 $this->container->get('package_manager.committer'), 28 $this->container->get('file_system'), 29 $this->container->get('event_dispatcher'), 30 $this->container->get('tempstore.shared'), 31 $this->container->get('datetime.time') 32 ); 33 if ($stage->isAvailable() || !$stage->isApplying()) { 34 return []; 35 } 36 if ($stage->isApplying()) { 37 $reasons[] = $this->t('The @module module cannot be uninstalled because staged changes are being applied to the active code base.', [ 38 '@module' => $module, - Comment on lines +37 to +38
I think we should clarify that current module being uninstalled is not necessarily the module that is doing updating. For instance if I saw the message:
The Webform module cannot be uninstalled because staged changes are being applied to the active code base.
I would probably assume "staged changes are being applied" had something to do with webform. This could be more confusing if module name contained update.
The Bulk Author Update module cannot be uninstalled because staged changes are being applied to the active code base.
Maybe something like:
The Webform module cannot be uninstalled because module uninstalls are not disabled when staged changes are being applied to the active code base by the Package Manager module.
changed this line in version 9 of the diff
added 3 commits
-
8fba6de0...5e5c7173 - 2 commits from branch
project:8.x-2.x - fdace39f - Merge branch '8.x-2.x' into 3267577-clean--up
-
8fba6de0...5e5c7173 - 2 commits from branch
