Issue #3267387: The readiness checker manager service is not longer needed in \Drupal\automatic_updates\Form\UpdaterForm
Merged
requested to merge issue/automatic_updates-3267387:3267387-the-readiness-checker into 8.x-2.x
2 unresolved threads
Merge request reports
Activity
51 50 * 52 51 * @var \Drupal\automatic_updates\Validation\ReadinessValidationManager 53 52 */ 54 53 protected $readinessValidationManager; changed this line in version 2 of the diff
99 95 /** 100 96 * {@inheritdoc} 101 97 */ 102 public static function create(ContainerInterface $container) { 98 public static function create(ContainerInterface $container): UpdaterForm { -
I'm not certain this will work, because it changes the function signature in a way that contradicts its definition in
\Drupal\Core\DependencyInjection\ContainerInjectionInterface::create(). If it does work, it may be thanks to the covariance support added in PHP 7.4, which means that we'll be implicitly dropping PHP 7.3 support. Which is probably fine, but worth pointing out.So, no action necessarily needed here unless the tests fail because of it. The more you know! /cc @tedbow
changed this line in version 3 of the diff
added 1 commit
- 50150f90 - reversed the create function due to contradiction with ContainerInjectionInterface
added 5 commits
-
50150f90...347cb2d2 - 2 commits from branch
project:8.x-2.x - fe85cee3 - removed use of readiness checker and confirmed tests passed
- 093f851b - removed unnecessary property
- 838def4b - reversed the create function due to contradiction with ContainerInjectionInterface
Toggle commit list-
50150f90...347cb2d2 - 2 commits from branch
Please register or sign in to reply