Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
automatic_updates
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
automatic_updates
Merge requests
!195
Issue
#3262303
: Always clear stored validation results when modules are installed or uninstalled
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Issue
#3262303
: Always clear stored validation results when modules are installed or uninstalled
issue/automatic_updates-3262303:3262303-always-clear-stored
into
8.x-2.x
Overview
0
Commits
4
Pipelines
0
Changes
3
Merged
Adam G-H
requested to merge
issue/automatic_updates-3262303:3262303-always-clear-stored
into
8.x-2.x
3 years ago
Overview
0
Commits
4
Pipelines
0
Changes
3
Expand
0
0
Merge request reports
Compare
8.x-2.x
version 8
93cbd7b3
3 years ago
version 7
4b63ea2b
3 years ago
version 6
3e4e8db3
3 years ago
version 5
50ee1152
3 years ago
version 4
81794995
3 years ago
version 3
8b32abb8
3 years ago
version 2
a6904450
3 years ago
version 1
a5201e5c
3 years ago
8.x-2.x (base)
and
latest version
latest version
93cbd7b3
4 commits,
3 years ago
version 8
93cbd7b3
4 commits,
3 years ago
version 7
4b63ea2b
3 commits,
3 years ago
version 6
3e4e8db3
2 commits,
3 years ago
version 5
50ee1152
1 commit,
3 years ago
version 4
81794995
7 commits,
3 years ago
version 3
8b32abb8
5 commits,
3 years ago
version 2
a6904450
4 commits,
3 years ago
version 1
a5201e5c
3 commits,
3 years ago
3 files
+
22
−
21
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
3
Search (e.g. *.vue) (Ctrl+P)
tests/src/Functional/ReadinessValidationTest.php
+
11
−
11
Options
@@ -317,19 +317,19 @@ class ReadinessValidationTest extends AutomaticUpdatesFunctionalTestBase {
$this
->
drupalGet
(
'admin/structure'
);
$assert
->
pageTextContainsOnce
(
$expected_results
[
0
]
->
getMessages
()[
0
]);
// Confirm that installing a module that does not provide a new checker does
// not run the checkers on install.
$unexpected_results
=
$this
->
testResults
[
'checker_1'
][
'2 errors 2 warnings'
];
TestChecker2
::
setTestResult
(
$unexpected_results
,
ReadinessCheckEvent
::
class
);
// Confirm that installing a module runs the checkers, even if the new
// module does not provide any validators.
$previous_results
=
$expected_results
;
$expected_results
=
$this
->
testResults
[
'checker_1'
][
'2 errors 2 warnings'
];
TestChecker2
::
setTestResult
(
$expected_results
,
ReadinessCheckEvent
::
class
);
$this
->
container
->
get
(
'module_installer'
)
->
install
([
'help'
]);
// Check for message on 'admin/structure' instead of the status report
// because
checke
rs will be run if needed on the status report.
// Check for message
s
on 'admin/structure' instead of the status report
,
// because
validato
rs will be run if needed on the status report.
$this
->
drupalGet
(
'admin/structure'
);
// Confirm that new checker message is not displayed because the checker was
// not run again.
$assert
->
pageTextContainsOnce
(
$expected_results
[
0
]
->
getMessages
()[
0
]);
$assert
->
pageTextNotContains
(
$unexpected_results
[
'1:errors'
]
->
getMessages
()[
0
]);
$assert
->
pageTextNotContains
(
$unexpected_results
[
'1:errors'
]
->
getSummary
());
// Confirm that new checker messages are displayed.
$assert
->
pageTextNotContains
(
$previous_results
[
0
]
->
getMessages
()[
0
]);
$assert
->
pageTextNotContains
(
$expected_results
[
'1:errors'
]
->
getMessages
()[
0
]);
$assert
->
pageTextContainsOnce
(
$expected_results
[
'1:errors'
]
->
getSummary
());
}
/**
Loading