Skip to content
Snippets Groups Projects

Issue #3230024: Collect exclusions from event objects

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ted Bowman
  • Ted Bowman
  • Adam G-H added 1 commit

    added 1 commit

    Compare with previous version

  • Adam G-H added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman
  • Adam G-H added 1 commit

    added 1 commit

    Compare with previous version

  • Adam G-H added 1 commit

    added 1 commit

    Compare with previous version

  • Adam G-H added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman
  • Ted Bowman
  • Adam G-H added 1 commit

    added 1 commit

    • ef68fa5b - ExcludedPathsTrait should be absolute for now

    Compare with previous version

  • Ted Bowman
  • Ted Bowman
  • Ted Bowman
    Ted Bowman @tedbow started a thread on the diff
  • 212 'settings.local.php',
    213 'services.yml',
    214 ];
    215 foreach ($settings_files as $settings_file) {
    216 $file_path = implode(DIRECTORY_SEPARATOR, [
    217 $this->appRoot,
    218 $this->sitePath,
    219 $settings_file,
    220 ]);
    221 $file_path = $this->fileSystem->realpath($file_path);
    222 if (file_exists($file_path)) {
    223 $exclusions[] = $file_path;
    224 }
    225 }
    226
    181 private function getExclusions($event): array {
    • Should we have the type hint of UpdateEvent here because we know at least it will be that? \Drupal\Tests\automatic_updates\Functional\ExclusionsTest::testExclusions still passes if added

    • Author Maintainer

      Well, the problem there is that PHPStorm will think that the object doesn't have getExcludedPaths() if we type hint it as UpdateEvent. I'd use a union type here, but that's not supported until PHP 8.

    • I am not seeing that PHPStorm behavior if I add UpdateEvent it still finds the method. I think PHPStorm, and other IDEs?, will take @param as more refinement. The 2 classes in @param are still extend UpdateEvent

    • Please register or sign in to reply
  • Ted Bowman
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading