Skip to content
Snippets Groups Projects

Issue #3247479: Allow LockFileValidator results to carry multiple messages, and improve their text

Closed Issue #3247479: Allow LockFileValidator results to carry multiple messages, and improve their text
issue/automatic_updates-3247479:3247479-allow-lockfilevalidator-results into 8.x-2.x
Closed Adam G-H requested to merge issue/automatic_updates-3247479:3247479-allow-lockfilevalidator-results into 8.x-2.x
Viewing commit 059443b7
Prev Next
Show latest version
3 files
+ 8
− 8
Compare changes
  • Side-by-side
  • Inline
Files
3
  • 059443b7
    omkar podey
    Issue #3341224 by omkar.podey, Wim Leers, phenaproxima: Always catch... · 059443b7
    omkar podey authored 
    Issue #3341224 by omkar.podey, Wim Leers, phenaproxima: Always catch \Throwable, not \Exception, and pass the old exception when re-throwing
package_manager/src/Validator/ComposerSettingsValidator.php
+ 2
− 2
@@ -45,8 +45,8 @@ final class ComposerSettingsValidator implements EventSubscriberInterface {
try {
$setting = (int) $this->inspector->getConfig('secure-http', $dir);
}
catch (\Exception $exception) {
$event->addErrorFromThrowable($exception, $this->t('Unable to determine Composer <code>secure-http</code> setting.'));
catch (\Throwable $throwable) {
$event->addErrorFromThrowable($throwable, $this->t('Unable to determine Composer <code>secure-http</code> setting.'));
return;
}
if ($setting !== 1) {