Skip to content
Snippets Groups Projects

Issue #3424290 check if file settings path exist

Merged Issue #3424290 check if file settings path exist
issue/automatic_updates-3424290:3424290-exclude-paths into 3.0.x
1 unresolved thread
Merged Ted Bowman requested to merge issue/automatic_updates-3424290:3424290-exclude-paths into 3.0.x
1 unresolved thread

Closes #3424290

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
package_manager/src/PathExcluder/SiteFilesExcluder.php
59 59 $path = $wrapper->getDirectoryPath();
60 60
61 61 if ($this->fileSystem->isAbsolutePath($path)) {
62 $event->addPathsRelativeToProjectRoot([realpath($path)]);
62 if ($path = realpath($path)) {
  • Adam G-H
    Adam G-H @phenaproxima ·
    Maintainer

    I'd rather we used $this->fileSystem->realpath() for this. Otherwise, no objections.

  • Ted Bowman
    Ted Bowman @tedbow ·
    Author Maintainer

    $this->fileSystem in this case is \Symfony\Component\Filesystem\Filesystem and it doesn't have realPath() method. Maybe you are thinking of \Drupal\Core\File\FileSystem::realpath but we don't have that service here. We are using just realpath() in multiple places.

  • Please register or sign in to reply
  • Ted Bowman merged

    merged

    • Please register or sign in to reply