Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
automatic_updates
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
automatic_updates
Commits
f7db960b
Commit
f7db960b
authored
1 year ago
by
Kunal Sachdev
Committed by
Adam G-H
1 year ago
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3339659
by kunal.sachdev, tedbow, yash.rode: UpdateReady form does not have primary button
parent
a65d64bf
No related branches found
Branches containing commit
Tags
8.x-2.0-alpha1
Tags containing commit
3 merge requests
!989
Issue #3356804 by phenaproxima: Flag a warning during status check if the...
,
!831
Issue #3339659: UpdateReady form does not have primary button
,
!548
Issue #3310729: Incorrect documentation link in UI in case of Process error
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/Form/UpdateReady.php
+1
-0
1 addition, 0 deletions
src/Form/UpdateReady.php
tests/src/Functional/AutomaticUpdatesFunctionalTestBase.php
+2
-0
2 additions, 0 deletions
tests/src/Functional/AutomaticUpdatesFunctionalTestBase.php
with
3 additions
and
0 deletions
src/Form/UpdateReady.php
+
1
−
0
View file @
f7db960b
...
...
@@ -164,6 +164,7 @@ final class UpdateReady extends UpdateFormBase {
'#type'
=>
'submit'
,
'#value'
=>
$this
->
t
(
'Continue'
),
];
$form
[
'actions'
][
'submit'
][
'#button_type'
]
=
'primary'
;
return
$form
;
}
...
...
This diff is collapsed.
Click to expand it.
tests/src/Functional/AutomaticUpdatesFunctionalTestBase.php
+
2
−
0
View file @
f7db960b
...
...
@@ -136,6 +136,8 @@ abstract class AutomaticUpdatesFunctionalTestBase extends BrowserTestBase {
$assert_session
=
$this
->
assertSession
();
$assert_session
->
addressMatches
(
'/\/admin\/automatic-update-ready\/[a-zA-Z0-9_\-]+$/'
);
$assert_session
->
pageTextContainsOnce
(
'Drupal core will be updated to '
.
$target_version
);
$button
=
$assert_session
->
buttonExists
(
"Continue"
);
$this
->
assertTrue
(
$button
->
hasClass
(
'button--primary'
));
}
/**
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment