remove property changes to files that require logic changes

package_manager/src/StageBase.php

@@ -150,7 +150,7 @@ abstract class StageBase implements LoggerAwareInterface {
    *
    * @var string[]
    */
-  private array $lock;
+  private $lock;
 
   /**
    * The shared temp store.
@@ -598,7 +598,7 @@ abstract class StageBase implements LoggerAwareInterface {
     $this->tempStore->delete(static::TEMPSTORE_METADATA_KEY);
     $this->tempStore->delete(static::TEMPSTORE_LOCK_KEY);
     $this->tempStore->delete(self::TEMPSTORE_STAGING_ROOT_KEY);
-    $this->lock = [];
+    $this->lock = NULL;
   }
 
   /**
@@ -747,7 +747,7 @@ abstract class StageBase implements LoggerAwareInterface {
    *   If this method is called before the stage has been created or claimed.
    */
   public function getStageDirectory(): string {
-    if (empty($this->lock)) {
+    if (!$this->lock) {
       throw new \LogicException(__METHOD__ . '() cannot be called because the stage has not been created or claimed.');
     }
     return $this->getStagingRoot() . DIRECTORY_SEPARATOR . $this->lock[0];

package_manager/tests/src/Kernel/ComposerInspectorTest.php

@@ -385,14 +385,14 @@ class ComposerInspectorTest extends PackageManagerKernelTestBase {
        *
        * @var string
        */
-      public string $packagePath;
+      public $packagePath;
 
       /**
        * {@inheritdoc}
        */
       protected function show(string $working_dir): array {
         $data = parent::show($working_dir);
-        if (isset($this->packagePath)) {
+        if ($this->packagePath) {
           $data['test/package']['path'] = $this->packagePath;
         }
         return $data;

package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php

@@ -61,7 +61,7 @@ abstract class PackageManagerKernelTestBase extends KernelTestBase {
    *
    * @see ::register()
    */
-  private Client $client;
+  private $client;
 
   /**
    * {@inheritdoc}
@@ -80,7 +80,7 @@ abstract class PackageManagerKernelTestBase extends KernelTestBase {
    *
    * @var string[]
    */
-  protected array $disableValidators = [];
+  protected $disableValidators = [];
 
   /**
    * The test root directory, if any, created by ::createTestProject().
@@ -151,7 +151,7 @@ abstract class PackageManagerKernelTestBase extends KernelTestBase {
 
     // If we previously set up a mock HTTP client in ::setReleaseMetadata(),
     // re-inject it into the container.
-    if (isset($this->client)) {
+    if ($this->client) {
       $container->set('http_client', $this->client);
     }
 
@@ -489,14 +489,14 @@ class TestDiskSpaceValidator extends DiskSpaceValidator {
    *
    * @var bool
    */
-  public bool $sharedDisk = TRUE;
+  public $sharedDisk = TRUE;
 
   /**
    * The amount of free space, keyed by path.
    *
    * @var float[]
    */
-  public array $freeSpace = [];
+  public $freeSpace = [];
 
   /**
    * {@inheritdoc}

tests/src/Functional/StatusCheckTest.php

@@ -17,7 +17,7 @@ use Drupal\package_manager_test_validation\EventSubscriber\TestSubscriber;
 use Drupal\system\SystemManager;
 use Drupal\Tests\automatic_updates\Traits\ValidationTestTrait;
 use Drupal\Tests\Traits\Core\CronRunTrait;
-use Drupal\user\Entity\User;
+use Drupal\user\UserInterface;
 
 /**
  * Tests status checks.
@@ -40,14 +40,14 @@ class StatusCheckTest extends AutomaticUpdatesFunctionalTestBase {
    *
    * @var \Drupal\user\Entity\User
    */
-  protected User $reportViewerUser;
+  protected UserInterface $reportViewerUser;
 
   /**
    * A user who can view the status report and run status checks.
    *
    * @var \Drupal\user\Entity\User
    */
-  protected User $checkerRunnerUser;
+  protected UserInterface $checkerRunnerUser;
 
   /**
    * The test checker.