Skip to content
Snippets Groups Projects
Commit 444e6482 authored by Yash Rode's avatar Yash Rode
Browse files

nitpicks

parent 5d918a72
No related branches found
No related tags found
No related merge requests found
This commit is part of merge request !534. Comments created here will be created in the context of that merge request.
...@@ -12,7 +12,7 @@ use Drupal\package_manager_test_api\ApiController as PackageManagerApiController ...@@ -12,7 +12,7 @@ use Drupal\package_manager_test_api\ApiController as PackageManagerApiController
class ApiController extends PackageManagerApiController { class ApiController extends PackageManagerApiController {
/** /**
* The stage. * The extension updater.
* *
* @var \Drupal\automatic_updates_extensions\ExtensionUpdater * @var \Drupal\automatic_updates_extensions\ExtensionUpdater
*/ */
...@@ -21,7 +21,7 @@ class ApiController extends PackageManagerApiController { ...@@ -21,7 +21,7 @@ class ApiController extends PackageManagerApiController {
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */
protected $finished_route = 'automatic_updates_extensions_test_api.finish'; protected $finishedRoute = 'automatic_updates_extensions_test_api.finish';
/** /**
* {@inheritdoc} * {@inheritdoc}
......
...@@ -19,7 +19,7 @@ class ApiController extends ControllerBase { ...@@ -19,7 +19,7 @@ class ApiController extends ControllerBase {
/** /**
* @var string * @var string
*/ */
protected $finished_route = 'package_manager_test_api.finish'; protected $finishedRoute = 'package_manager_test_api.finish';
/** /**
* The stage. * The stage.
...@@ -89,7 +89,7 @@ class ApiController extends ControllerBase { ...@@ -89,7 +89,7 @@ class ApiController extends ControllerBase {
*/ */
public function run(Request $request): RedirectResponse { public function run(Request $request): RedirectResponse {
$id = $this->createAndApplyStage($request); $id = $this->createAndApplyStage($request);
$redirect_url = Url::fromRoute($this->finished_route) $redirect_url = Url::fromRoute($this->finishedRoute)
->setRouteParameter('id', $id) ->setRouteParameter('id', $id)
->setOption('query', [ ->setOption('query', [
'files_to_return' => $request->get('files_to_return', []), 'files_to_return' => $request->get('files_to_return', []),
......
...@@ -17,9 +17,9 @@ class TestController extends PackageManagerApiController { ...@@ -17,9 +17,9 @@ class TestController extends PackageManagerApiController {
protected $stage; protected $stage;
/** /**
* @var string * {@inheritdoc}
*/ */
protected $finished_route = 'automatic_updates_test.finish'; protected $finishedRoute = 'automatic_updates_test.finish';
/** /**
* {@inheritdoc} * {@inheritdoc}
......
...@@ -80,7 +80,7 @@ class CoreUpdateTest extends UpdateTestBase { ...@@ -80,7 +80,7 @@ class CoreUpdateTest extends UpdateTestBase {
$assert_session = $mink->assertSession(); $assert_session = $mink->assertSession();
$session = $mink->getSession(); $session = $mink->getSession();
$session->reload(); $session->reload();
$file_contents = $mink->getSession()->getPage()->getContent(); $file_contents = $session->getPage()->getContent();
$file_contents = json_decode($file_contents, TRUE); $file_contents = json_decode($file_contents, TRUE);
$drupal_php = $file_contents[$file_path]; $drupal_php = $file_contents[$file_path];
$this->assertStringContainsString("const VERSION = '9.8.1';", $drupal_php); $this->assertStringContainsString("const VERSION = '9.8.1';", $drupal_php);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment