Display the roles label instead of its machine name

Closes #3481995

src/Form/ApplyForRoleApplicationForm.php

@@ -12,7 +12,7 @@ namespace Drupal\apply_for_role\Form;
 use Drupal\Core\Form\FormBase;
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\apply_for_role\application_manager;
-
+use Drupal\user\Entity\Role;
 
 class ApplyForRoleApplicationForm extends FormBase{
   private $application_manager;
@@ -45,7 +45,7 @@ class ApplyForRoleApplicationForm extends FormBase{
       }
     }
 
-
+    $available_roles = $this->getCleanRoleLabel($available_roles);
     // Go through all roles, find roles with a value of 0 and unset them
     foreach($available_roles as $available_role_key => $available_role){
       if($available_role === 0){
@@ -120,6 +120,24 @@ class ApplyForRoleApplicationForm extends FormBase{
     $this->messenger()->addStatus(t('Thank you for submitting an applicaton. Your requested is currently queued for review.'));
   }
 
+  /**
+   * This will display the role's label instead of its machine name.
+   *
+   * @param array $available_roles
+   *  List available roles.
+   * @return array
+   *  An array with machine names as keys and corresponding labels as values.
+   */
+  protected function getCleanRoleLabel (array $available_roles): array {
+    $roles = [];
+    foreach (Role::loadMultiple() as $role) {
+      if (isset($available_roles[$role->id()]) && $available_roles[$role->id()]) {
+        $roles[$role->id()] = $role->label();
+      }
+    }
+    return $roles;
+  }
+
   /**
    * Helper function that fetches the roles a user has.
    *

[Frederik V]

Try to do it the other way around, no need to load all roles. You already load just the configured role's machines names from config, loop over those and convert them there.