Skip to content
Snippets Groups Projects

Honor locale option in all CRUD methods

Merged Coby Sher requested to merge issue/api_client-3376932:honor-locale into canary

Given the abstractions already in the class, this was fairly straightforward.

  • The RequestBaseOptions class now includes the locale option
  • create, update, and delete methods now use the locale option to create the URL
  • Added tests - these were a bit lazy as they do not include the response from the translated API. I'm not sure how much this matters but it could probably be more accurate.

Merge request reports

Approval is optional
License Compliance test metrics results are being parsed

Merged by Brian PerryBrian Perry 11 months ago (Feb 25, 2024 4:21pm UTC)

Merge details

  • Changes merged into canary with f602272a (commits were squashed).
  • Did not delete the source branch.
  • Auto-merge enabled

Pipeline #103513 passed

Pipeline passed for f602272a on canary

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading