Skip to content
Snippets Groups Projects

Simple OAuth

Merged Coby Sher requested to merge issue/api_client-3376946:simple-oauth-3376946 into canary
All threads resolved!
  • Add getAccessToken method to ApiClient
  • Call getAccessToken if the auth type is oauth
  • Refactor auth types to use generics This should allow proper types based on the auth wanted by the user. Should make it a bit easer to add new auth types that expect different credentials
  • Add tests

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Brian Perry
    • Resolved by Brian Perry

      Nice work on this - works well for me locally. Only thing I think would be worth changing is that I think we can still use the custom fetch option (if provided) when fetching the token even if we can't use this.fetch.

  • Coby Sher added 2 commits

    added 2 commits

    • 093aa50f - Use custom fetch for api token, update doc for type
    • 2940ef17 - Add changeset

    Compare with previous version

  • Coby Sher resolved all threads

    resolved all threads

  • Brian Perry added 1 commit

    added 1 commit

    • 20fe5cae - Additional test coverage for using custom fetch with OAuth

    Compare with previous version

  • Brian Perry resolved all threads

    resolved all threads

  • Brian Perry approved this merge request

    approved this merge request

  • merged

  • Please register or sign in to reply
    Loading