Update error handling for fetch

We can add an onError option in the future that will be called instead of throwing the error, but for now it's good to have at least some way to bubble up errors from fetch

• Refactor the return type for fetch
  • fetch now returns an object with the response if no errors occurred, or an error if one occurred.
  • the error will need to be handled by the method calling fetch. at the moment the methods will simply re-throw the error and log it to the console if debug is on - at the moment we are also logging in fetch regardless of debug. This part I'm least sure about. Should we move debug to the base class and only log in fetch if debug is true. Either way seems ok to me but I would like a second opinion.

changed the description

added 1 commit

• e40d3afb - Update error handling for fetch

Compare with previous version

added 1 commit

• 12377f22 - Update error handling for fetch

Compare with previous version

added 1 commit

• 12e7bce3 - Update error handling for fetch

Compare with previous version

Should we move debug to the base class and only log in fetch if debug is true.

That makes sense to me if you want to make that change on this MR.

Just a couple of small typos in the example. And I do agree that it makes sense to move the debug logging into the base class so we can control that in fetch as well.

added 1 commit

• 1ea7912a - CR updates:

Compare with previous version

resolved all threads

added 1 commit

• 076309e0 - Remove debug field

Compare with previous version

approved this merge request

merged