Skip to content
Snippets Groups Projects

3398412: Adds method to delete resource in jsonapi client.

Merged Pratik Kamble requested to merge issue/api_client-3398412:api_client-3398412 into canary
All threads resolved!

Merge request reports

Pipeline #62674 passed

Pipeline passed for 479bf96f on issue:api_client-3398412

Approval is optional

Merged by Pratik KamblePratik Kamble 1 year ago (Dec 12, 2023 3:23pm UTC)

Merge details

  • Changes merged into with 565d7106.
  • Did not delete the source branch.

Pipeline #62679 passed

Pipeline passed for 565d7106 on canary

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Coby Sher
  • Coby Sher
  • Looks good, just a few questions about some implementation details and some things for either new or future issues.

  • Oh needs a changeset as well.

  • Brian Perry added 2 commits

    added 2 commits

    • a92871ad - Use debug mode in tests for additonal coverage
    • d9d72236 - Refactor CreateCacheKeyParams into more re-usable EndpointUrlSegments type

    Compare with previous version

  • Brian Perry
  • This looks good to me - pushed up some small test coverage and types/docs changes that probably need one more look.

  • Brian Perry approved this merge request

    approved this merge request

  • Brian Perry resolved all threads

    resolved all threads

  • Coby Sher approved this merge request

    approved this merge request

  • Pratik Kamble added 6 commits

    added 6 commits

    • 8c8571bc - 1 commit from branch project:canary
    • 57b5781d - 3398412: Adds method to delete resource in jsonapi client.
    • 6dd74ca2 - 3398412: Adds unit test case for deleteResource.
    • 76634d49 - Use debug mode in tests for additonal coverage
    • a145fa14 - Refactor CreateCacheKeyParams into more re-usable EndpointUrlSegments type
    • 479bf96f - 3398412: Adds changeset.

    Compare with previous version

  • Coby Sher approved this merge request

    approved this merge request

  • merged

  • Please register or sign in to reply
    Loading