Skip to content
Snippets Groups Projects

[json-api-client] adds getView method

Merged Brian Perry requested to merge issue/api_client-3462889:views into canary
All threads resolved!
  • Implements getView method
  • Adjusts supporting functions like createCacheKey to support views
  • Adds jsonapi_views to local environment.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Brian Perry
  • Brian Perry
  • Author Maintainer

    Tests look great @D34dMan. They also helped me realize a possible bug with namespacing. Will push up an update for that in a bit.

  • Brian Perry resolved all threads

    resolved all threads

  • Brian Perry added 1 commit

    added 1 commit

    • cfb412d1 - Namespace view cache keys to prevent collisions

    Compare with previous version

  • Shibin Das
  • @backlineint thanks for the review request, I just have a minor nitpick and should be good to go.

  • Brian Perry added 1 commit

    added 1 commit

    • 94746ce6 - Added comment explaining why we are prefixing views cache key

    Compare with previous version

  • Brian Perry marked this merge request as ready

    marked this merge request as ready

  • Brian Perry added 1 commit

    added 1 commit

    Compare with previous version

  • Brian Perry resolved all threads

    resolved all threads

  • Brian Perry enabled an automatic merge when the pipeline for 94d0e7ce succeeds

    enabled an automatic merge when the pipeline for 94d0e7ce succeeds

  • Brian Perry aborted the automatic merge because target branch was updated

    aborted the automatic merge because target branch was updated

  • Brian Perry added 3 commits

    added 3 commits

    • d21ef95f - 1 commit from branch project:canary
    • b561fecc - Merge branch 'canary' into views
    • 1863097d - Tweak local install script

    Compare with previous version

  • Brian Perry added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading